Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

State screen does not reflect force arrows #283

Closed
loganbraywork opened this issue May 18, 2020 · 3 comments
Closed

State screen does not reflect force arrows #283

loganbraywork opened this issue May 18, 2020 · 3 comments
Assignees
Labels

Comments

@loganbraywork
Copy link

Test Device

Windows 10

Operating System

Windows 10 1903

Browser

Firefox 76.0.1

Problem Description

For phetsims/qa#501

This appears to be the result of the bug mentioned in #274. The state screen appears to reflect the correct position of the force arrows, while the original screen reflects the bugged arrow positions.

Steps to Reproduce

  1. Select adjustable attraction
  2. Select show repulsive and attractive force arrows
  3. Pause simulation
  4. Move atom closer to the fixed atom
  5. Switch to argon atoms
  6. Switch back to adjustable attraction atoms
  7. Unpause simulation

Visuals

2020-05-18StatesPhetiostatesArrows

@jbphet
Copy link
Contributor

jbphet commented May 29, 2020

@arouinfar and I reviewed this on 5/29/2020 and we decided that it does not need to be fixed for an early customer dev release (since the customer is not expected to use this screen), but it should be addressed before a full phet-io release of this sim.

@jbphet
Copy link
Contributor

jbphet commented Jun 19, 2020

This is now fixed, see the description in #274 (comment).

@KatieWoe - please check on master. If it looks good, go ahead and close, since it has the same root cause as #274 so we don't need to re-verify on the next release.

@jbphet jbphet assigned KatieWoe and unassigned jbphet Jun 19, 2020
@KatieWoe
Copy link
Contributor

Looks good on master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants