Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Center line missing on interaction potential chart #259

Closed
jbphet opened this issue Mar 3, 2020 · 4 comments
Closed

Center line missing on interaction potential chart #259

jbphet opened this issue Mar 3, 2020 · 4 comments

Comments

@jbphet
Copy link
Contributor

jbphet commented Mar 3, 2020

The current interaction potential chart on the "Phase Changes" screen is missing the horizontal center line. It looks like this:

image

The live version (v 1.1.10) looks like this:

image

@jbphet
Copy link
Contributor Author

jbphet commented Mar 3, 2020

After doing some forensics, it looks like this was removed in an attempt to fix the problem that the center axis line goes over the potential (red) line in phetsims/atomic-interactions#75.

Specifically, here is what I think is the problematic commit: bc510f7

@jbphet
Copy link
Contributor Author

jbphet commented Mar 3, 2020

I've made some changes, here's what it looks like now (using water as the substance, which makes the line more apparent):

image

@jbphet
Copy link
Contributor Author

jbphet commented Mar 3, 2020

@SaurabhTotey - please review. It looks like you made the commit that removed the line, and I wanted to make sure that this wasn't intentional. If all looks good, please close.

@SaurabhTotey
Copy link
Member

Oh, I completely missed this side-effect! It wasn't my intention to remove the line for the interaction potential chart, but it looks good now. Closing.

@SaurabhTotey SaurabhTotey removed their assignment Mar 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants