Skip to content

Commit

Permalink
require "RadioButton" suffix for for radio buttons, phetsims/sun#615
Browse files Browse the repository at this point in the history
  • Loading branch information
pixelzoom committed Aug 13, 2020
1 parent 6bca2e5 commit 1e88872
Show file tree
Hide file tree
Showing 4 changed files with 23 additions and 23 deletions.
20 changes: 10 additions & 10 deletions js/atomic-interactions/view/AtomicInteractionsControlPanel.js
Original file line number Diff line number Diff line change
Expand Up @@ -189,37 +189,37 @@ class AtomicInteractionsControlPanel extends Node {
{
node: createLabelNode( neonAndNeonLabelItems ),
value: AtomPair.NEON_NEON,
tandemName: 'neonAndNeon'
tandemName: 'neonAndNeonRadioButton'
},
{
node: createLabelNode( argonAndArgonLabelItems ),
value: AtomPair.ARGON_ARGON,
tandemName: 'argonAndArgon'
tandemName: 'argonAndArgonRadioButton'
},
{
node: createLabelNode( oxygenAndOxygenLabelItems ),
value: AtomPair.OXYGEN_OXYGEN,
tandemName: 'oxygenAndOxygen'
tandemName: 'oxygenAndOxygenRadioButton'
},
{
node: createLabelNode( neonAndArgonLabelItems ),
value: AtomPair.NEON_ARGON,
tandemName: 'neonAndArgon'
tandemName: 'neonAndArgonRadioButton'
},
{
node: createLabelNode( neonAndOxygenLabelItems ),
value: AtomPair.NEON_OXYGEN,
tandemName: 'neonAndOxygen'
tandemName: 'neonAndOxygenRadioButton'
},
{
node: createLabelNode( argonAndOxygenLabelItems ),
value: AtomPair.ARGON_OXYGEN,
tandemName: 'argonAndOxygen'
tandemName: 'argonAndOxygenRadioButton'
},
{
node: customAttractionLabel,
value: AtomPair.ADJUSTABLE,
tandemName: 'adjustable'
tandemName: 'adjustableRadioButton'
}
],
{
Expand Down Expand Up @@ -315,17 +315,17 @@ class AtomicInteractionsControlPanel extends Node {
{
value: AtomPair.NEON_NEON,
node: createLabelNode( neon ),
tandemName: 'neon'
tandemName: 'neonRadioButton'
},
{
value: AtomPair.ARGON_ARGON,
node: createLabelNode( argon ),
tandemName: 'argon'
tandemName: 'argonRadioButton'
},
{
value: AtomPair.ADJUSTABLE,
node: createLabelNode( adjustableAttraction ),
tandemName: 'adjustableAttraction'
tandemName: 'adjustableAttractionRadioButton'
}
];
const radioButtonGroup = new RadioButtonGroup( dualAtomModel.atomPairProperty, radioButtonContent, {
Expand Down
6 changes: 3 additions & 3 deletions js/atomic-interactions/view/ForcesAccordionBox.js
Original file line number Diff line number Diff line change
Expand Up @@ -196,17 +196,17 @@ class ForcesAccordionBox extends AccordionBox {
{
node: hideForce,
value: ForceDisplayMode.HIDDEN,
tandemName: 'hideForce'
tandemName: 'hideForceRadioButton'
},
{
node: totalForce,
value: ForceDisplayMode.TOTAL,
tandemName: 'totalForce'
tandemName: 'totalForceRadioButton'
},
{
node: componentForce,
value: ForceDisplayMode.COMPONENTS,
tandemName: 'componentForce'
tandemName: 'componentForceRadioButton'
}
],
{
Expand Down
10 changes: 5 additions & 5 deletions js/phase-changes/view/PhaseChangesMoleculesControlPanel.js
Original file line number Diff line number Diff line change
Expand Up @@ -148,22 +148,22 @@ class PhaseChangesMoleculesControlPanel extends Node {
{
value: SubstanceType.NEON,
node: new SubstanceSelectorNode( neonSelectorInfo.label, neonSelectorInfo.icon, selectorWidth ),
tandemName: 'neon'
tandemName: 'neonRadioButton'
},
{
value: SubstanceType.ARGON,
node: new SubstanceSelectorNode( argonSelectorInfo.label, argonSelectorInfo.icon, selectorWidth ),
tandemName: 'argon'
tandemName: 'argonRadioButton'
},
{
value: SubstanceType.DIATOMIC_OXYGEN,
node: new SubstanceSelectorNode( oxygenSelectorInfo.label, oxygenSelectorInfo.icon, selectorWidth ),
tandemName: 'oxygen'
tandemName: 'oxygenRadioButton'
},
{
value: SubstanceType.WATER,
node: new SubstanceSelectorNode( waterSelectorInfo.label, waterSelectorInfo.icon, selectorWidth ),
tandemName: 'water'
tandemName: 'waterRadioButton'
}
];

Expand All @@ -175,7 +175,7 @@ class PhaseChangesMoleculesControlPanel extends Node {
adjustableAttractionSelectorInfo.icon,
selectorWidth
),
tandemName: 'adjustableAttraction'
tandemName: 'adjustableAttractionRadioButton'
}
);
}
Expand Down
10 changes: 5 additions & 5 deletions js/states/view/StatesMoleculesControlPanel.js
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,8 @@ import SubstanceType from '../../common/SubstanceType.js';
import AtomAndMoleculeIconFactory from '../../common/view/AtomAndMoleculeIconFactory.js';
import SOMColorProfile from '../../common/view/SOMColorProfile.js';
import SubstanceSelectorNode from '../../common/view/SubstanceSelectorNode.js';
import statesOfMatterStrings from '../../statesOfMatterStrings.js';
import statesOfMatter from '../../statesOfMatter.js';
import statesOfMatterStrings from '../../statesOfMatterStrings.js';

const argonString = statesOfMatterStrings.argon;
const atomsAndMoleculesString = statesOfMatterStrings.AtomsAndMolecules;
Expand Down Expand Up @@ -121,14 +121,14 @@ class StatesMoleculesControlPanel extends Node {
};

const radioButtonContent = [
{ value: SubstanceType.NEON, node: createSelectionNode( neonSelectionNodeSpec ), tandemName: 'neon' },
{ value: SubstanceType.ARGON, node: createSelectionNode( argonSelectionNodeSpec ), tandemName: 'argon' },
{ value: SubstanceType.NEON, node: createSelectionNode( neonSelectionNodeSpec ), tandemName: 'neonRadioButton' },
{ value: SubstanceType.ARGON, node: createSelectionNode( argonSelectionNodeSpec ), tandemName: 'argonRadioButton' },
{
value: SubstanceType.DIATOMIC_OXYGEN,
node: createSelectionNode( oxygenSelectionNodeSpec ),
tandemName: 'oxygen'
tandemName: 'oxygenRadioButton'
},
{ value: SubstanceType.WATER, node: createSelectionNode( waterSelectionNodeSpec ), tandemName: 'water' }
{ value: SubstanceType.WATER, node: createSelectionNode( waterSelectionNodeSpec ), tandemName: 'waterRadioButton' }
];

const radioButtonGroup = new RadioButtonGroup( substanceProperty, radioButtonContent, {
Expand Down

0 comments on commit 1e88872

Please sign in to comment.