Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deploy from the 1.2 branch #31

Closed
jbphet opened this issue Aug 21, 2020 · 5 comments
Closed

Deploy from the 1.2 branch #31

jbphet opened this issue Aug 21, 2020 · 5 comments
Assignees

Comments

@jbphet
Copy link
Contributor

jbphet commented Aug 21, 2020

Version 1.2.0 of states-of-matter (SOM) - the "parent sim" of states-of-matter-basics (SOMB) - was just deployed. The main purpose of this release was to add phet-io functionality, but there were also a number of bug fixes and other changes. SOMB 1.2.0 should be deployed using the same code as SOM so that it also picks up the phet-io functionality and bug fixes.

@jbphet
Copy link
Contributor Author

jbphet commented Aug 21, 2020

One notable reason to do this deployment sooner rather than later is phetsims/states-of-matter#310 (comment).

@ariel-phet
Copy link

Marking as medium priority, as I agree this task would be good to complete sooner than later. Lets try to get into QA pipeline by mid November (sooner being ideal). Sounds like @jbphet might have some time this Friday.

@jbphet
Copy link
Contributor Author

jbphet commented Nov 2, 2020

@arouinfar, @kathy-phet, and I discussed whether or not to include the phet-io brand with this release, and we agreed that we should include it. Here's the Slack dialog:

@jbphet 10:40 AM
K**** and A**** - I have "States of Matter: Basics" all set for an RC using the code that was used for the recent "States of Matter" release. I have been assuming that I should publish both the PhET and PhET-iO brands, but it occurred to me that I should probably check in with you on this. Shall I move forward with both brands? (edited)

@arouinfar 10:47 AM
I think we should probably include both brands, especially since the client originally wanted to use the basics version.

@jbphet 11:01 AM
Sounds reasonable. Will it require any changes to the client guide?

@arouinfar 11:02 AM
It shouldn’t. I created SOMB-specific guides at the same times as the ones for SOM, and any tweaks that were made to SOM guides during QA were also applied to SOMB.

@jbphet 11:04 AM
Sounds good.
Next question: I'm assuming that I should NOT publish the phet-io version of Atomic Interactions, and just publish the phet brand. Sound good?

@arouinfar 11:04 AM
That sounds good to me. There was never any phet-io design review of Atomic Interactions.

@kathy-phet 11:05 AM
Both decisions sound good. When we have a request for Atomic Interactions PhET-iO, we can prioritize finishing that up.

@jbphet
Copy link
Contributor Author

jbphet commented Nov 2, 2020

Here's the QA task for the first serious release on this branch: phetsims/qa#574. This is for rc.3, and the reason that it's not 1 is because initially I was trying to put the 1.2 release of this sim out at the same time as the primary SOM release, but that plan was aborted due to limited bandwidth in QA.

jbphet added a commit that referenced this issue Dec 15, 2020
jbphet added a commit that referenced this issue Dec 15, 2020
(cherry picked from commit ef7a400)
@jbphet
Copy link
Contributor Author

jbphet commented Dec 15, 2020

Deployment complete, closing.

@jbphet jbphet closed this as completed Dec 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants