Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Slight pointer area overlap #21

Closed
KatieWoe opened this issue Mar 25, 2019 · 2 comments
Closed

Slight pointer area overlap #21

KatieWoe opened this issue Mar 25, 2019 · 2 comments
Assignees
@jbphet
Labels
type:bug

Comments

@KatieWoe
Copy link
Contributor

For phetsims/qa#297
When the sim is paused the pause/unpause button is a bit bigger, meaning that the pointer area for the button overlaps just a bit with the step forward button. Sorry this wasn't caught earlier. Likely minor due to the very small amount of overlap.
overlappointspause
jbphet added a commit to phetsims/states-of-matter that referenced this issue Apr 3, 2019
@jbphet
reduced the touch area dilation, see phetsims/states-of-matter-basics#21
985599f
jbphet added a commit to phetsims/states-of-matter that referenced this issue Apr 3, 2019
@jbphet
reduced the touch area dilation, see phetsims/states-of-matter-basics#21
03416a3 


(cherry picked from commit 985599f)
jbphet added a commit that referenced this issue Apr 3, 2019
@jbphet
incorporated fix for touch area overlap, see #21
ddee615
@jbphet
Copy link
Contributor

jbphet commented Apr 3, 2019

I reduced the touch area dilation, it now looks like this:

image

@jbphet
Copy link
Contributor

jbphet commented Apr 3, 2019

This was a minor fix, easily verified, so I did it and went ahead and deployed the production version. Closing.

@jbphet jbphet closed this as completed Apr 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jbphet jbphet

Labels
type:bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jbphet @KatieWoe