Move soccerBallsEnabledProperty under the soccerBallNodes parent tand…

…em, see: phetsims/mean-share-and-balance#254
phetsims · Jun 3, 2024 · 7deff92 · 7deff92
1 parent 6c19e30
commit 7deff92
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 3 deletions.
diff --git a/js/view/SoccerBallNode.ts b/js/view/SoccerBallNode.ts
@@ -144,8 +144,6 @@ export default class SoccerBallNode extends SoccerObjectNode {
     } );
 
     this.addLinkedElement( soccerBall );
-    this.addLinkedElement( soccerBallsEnabledProperty );
-
     super.addDebugText( soccerBall );
   }
 }

diff --git a/js/view/SoccerSceneView.ts b/js/view/SoccerSceneView.ts
@@ -85,15 +85,23 @@ export default class SoccerSceneView<SceneModel extends SoccerSceneModel = Socce
     const frontLayer = new Node();
 
     sceneModel.soccerBalls.map( ( soccerBall, index ) => {
+
+      const soccerBallParentTandem = options.tandem.createTandem( 'soccerBallNodes' );
+
       const soccerBallNode = new SoccerBallNode(
         soccerBall,
         modelViewTransform,
         soccerBallsEnabledProperty, {
           visibleProperty: new DerivedProperty( [ soccerBall.soccerBallPhaseProperty ], options.soccerBallDerivedVisibilityCallback ),
-          tandem: options.tandem.createTandem( 'soccerBallNodes' ).createTandem1Indexed( 'soccerBallNode', index ),
+          tandem: soccerBallParentTandem.createTandem1Indexed( 'soccerBallNode', index ),
           pickable: false
         } );
 
+      // We want the soccerBallsEnabledProperty to be linked under the parent tandem for all the SoccerBallNodes.
+      index === 0 && soccerBallNode.addLinkedElement( soccerBallsEnabledProperty, {
+        tandem: soccerBallParentTandem.createTandem( 'soccerBallsEnabledProperty' )
+      } );
+
       backLayerSoccerBallLayer.addChild( soccerBallNode );
 
       // While flying, it should be in front in z-order, to be in front of the accordion box
-Original file line number
+Diff line change
@@ Expand Up @@
         } );
         this.addLinkedElement( soccerBall );
-        this.addLinkedElement( soccerBallsEnabledProperty );
         super.addDebugText( soccerBall );
       }
     }
@@ Expand Down @@