remove TODOs, #38

phetsims · Aug 2, 2023 · b5a924e · b5a924e
1 parent 2349594
commit b5a924e
Show file tree

Hide file tree

Showing 4 changed files with 2 additions and 7 deletions.
diff --git a/js/AtomIdentifier.ts b/js/AtomIdentifier.ts
@@ -14145,8 +14145,7 @@ const AtomIdentifier = {
       return false;
     }
 
-    // TODO: should not require jquery dependency, https://github.com/phetsims/shred/issues/38
-    return $.inArray( numNeutrons, tableEntry ) > -1;
+    return tableEntry.includes( numNeutrons );
   },
 
   getNumNeutronsInMostCommonIsotope: function( atomicNumber: number ): number {

diff --git a/js/model/Particle.ts b/js/model/Particle.ts
@@ -185,10 +185,8 @@ class Particle extends PhetioObject {
   }
 
   public setPositionAndDestination( newPosition: Vector2 ): void {
-    if ( newPosition instanceof Vector2 ) { // TODO: remove this check, let TypeScript do the work, https://github.com/phetsims/shred/issues/38
       this.destinationProperty.set( newPosition );
       this.moveImmediatelyToDestination();
-    }
   }
 
   public static ParticleIO = new IOType( 'ParticleIO', {

diff --git a/js/model/ParticleAtom.ts b/js/model/ParticleAtom.ts
@@ -59,8 +59,6 @@ class ParticleAtom extends PhetioObject {
   private readonly nucleonRadius: number;
   public readonly positionProperty: TProperty<Vector2>;
   public readonly nucleusOffsetProperty: TProperty<Vector2>;
-
-  // TODO: must be public for BAN, see https://github.com/phetsims/shred/issues/38
   public readonly protons: ObservableArray<Particle>;
   public readonly neutrons: ObservableArray<Particle>;
   public readonly electrons: ObservableArray<Particle>;

diff --git a/js/view/ExpandedPeriodicTableNode.ts b/js/view/ExpandedPeriodicTableNode.ts
@@ -63,7 +63,7 @@ class ExpandedPeriodicTableNode extends Node {
     }
     for ( let i = 0; i < rows; i++ ) {
       const populatedCellsInRow = POPULATED_CELLS[ i ];
-      // TODO: test this, https://github.com/phetsims/shred/issues/38
+
       for ( let j = 0; j < populatedCellsInRow.length; j++ ) {
         const atomicNumber = elementIndex;
         const button = new TextPushButton( AtomIdentifier.getSymbol( elementIndex ), {