Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CT: AccessibleSiblingTests: sibling positioning failed #981

Closed
pixelzoom opened this issue Jun 16, 2019 · 1 comment
Closed

CT: AccessibleSiblingTests: sibling positioning failed #981

pixelzoom opened this issue Jun 16, 2019 · 1 comment
Assignees
@jessegreenberg
Labels
type:automated-testing type:bug

Comments

@pixelzoom
Copy link
Contributor

pixelzoom commented Jun 16, 2019 •
edited
Loading

scenery is failing CT with:

294 out of 295 tests passed. 1 failed.
AccessibleSiblingTests: sibling positioning failed:
button element descendant correctly positioned
    at Object.<anonymous> (https://bayes.colorado.edu/continuous-testing/snapshot-1560630770066/scenery/js/accessibility/AccessibleSiblingTests.js?bust=1560633396475:79:12)```

Looks like this started on 6/14/2019, 3:05:05 PM

@jessegreenberg looks like this might be the problem: 59746e7
@jessegreenberg jessegreenberg mentioned this issue Jun 16, 2019
Closed
jessegreenberg added a commit that referenced this issue Jun 16, 2019
@jessegreenberg
use for PDOM elements, use workaround instead for phetsims/joist#140 …
d58d04a 
…and #981
@jessegreenberg
Copy link
Contributor

Thanks for reporting, the above fixes the issue with unit tests and we will continue in phetsims/joist#140 to verify that the original issue is still resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jessegreenberg jessegreenberg

Labels
type:automated-testing type:bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@pixelzoom @jessegreenberg