Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document AccessibleInstance.initializeAccessibleInstance #758

Closed
zepumph opened this issue Mar 31, 2018 · 3 comments
Closed

Document AccessibleInstance.initializeAccessibleInstance #758

zepumph opened this issue Mar 31, 2018 · 3 comments
Assignees
@zepumph

Comments

@zepumph
Copy link
Member

zepumph commented Mar 31, 2018

This issue should be pretty quick, from #748

@jessegreenberg can you please add a bit more documentation to this method
AccessibleInstance.initializeAccessibleInstance I see a difference in the jsDoc from the args, and I didn't want to assume anything. You would know best! Let me know if you want to talk about it.
jessegreenberg added a commit that referenced this issue Apr 3, 2018
@jessegreenberg
add JSDoc for AccessibleInstance, see #758
efadbf5
@jessegreenberg
Copy link
Contributor

@zepumph I improved the documentation and filled in missing JSDoc for initializeAccessibleInstance and the constructor. There are a few other functions that need some documentation.

jessegreenberg added a commit that referenced this issue Apr 3, 2018
@jessegreenberg
improve documentation in AccessibleInstance, see #758
8da6986
@jessegreenberg
Copy link
Contributor

@zepumph I improved the documentation for AccessibleInstance, could you please review?

zepumph added a commit that referenced this issue Apr 4, 2018
@zepumph
cleanup, #758
2cfd5d5
@zepumph
Copy link
Member Author

zepumph commented Apr 4, 2018

Looks great thanks.

@zepumph zepumph closed this as completed Apr 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zepumph zepumph

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jessegreenberg @zepumph