-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fuzzBoard errors from first run #719
Comments
Very nice, thanks @zepumph. This one shows up a lot:
|
Unassigning for now. |
Also removing assignment until I have more time to work on this. |
@zepumph @jessegreenberg I forgot to tag you both. Just bumping and pointing to my above comment. |
That seems like a really nice, long term, robust solution for this problem. Right now, and most recently when working with the Tagging @samreid because I think that we have discussed the potential for pupeteer in some other testing, perhaps fuzzMouse, before. It is good to note that this enhancement would directly assist a11y testing. For now I think the priority should be getting rid of the errors that we see in the current implementation of |
I recall we've previously discussed puppeteer for automated testing, but I'm not sure what all the pros and cons are, nor do I know how the current implementation of ?fuzzBoard works. |
Regarding:
This may go away if we convert MenuItem to use pressListener rather than ButtonListener. I'll make an issue to investigate. It would clean up the a11y code in MenuItem anyways. Tagging @jessegreenberg too. |
because of #831, most of these fixed. I think we should close this and cover issues individually. Closing |
I can only assume that these aren't all keyboard related, but I thought it would be good to have a central issue to track all of the new fuzzBoard errors that are revealed so that we can have a good idea of our progress, and when we are ready to add fuzzBoard to bayes.
@jessegreenberg @mbarlow12 we should crank away at these async.
The text was updated successfully, but these errors were encountered: