Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Pool.ts instead of Poolable.ts in PDOMInstance #1543

Closed
marlitas opened this issue Mar 7, 2023 · 1 comment
Closed

Use Pool.ts instead of Poolable.ts in PDOMInstance #1543

marlitas opened this issue Mar 7, 2023 · 1 comment
Assignees
@zepumph
Labels
dev:typescript priority:3-medium

Comments

@marlitas
Copy link
Contributor

marlitas commented Mar 7, 2023

We want to make sure all typescript files are now using Pool through composition instead of through a mixin. PDOMInstance.ts is the last file remaining. This come from this issue phetsims/phet-core#103 in phet-core.
@marlitas marlitas mentioned this issue Mar 7, 2023
Closed
@zepumph zepumph self-assigned this Mar 7, 2023
zepumph added a commit to phetsims/scenery-phet that referenced this issue Mar 9, 2023
@zepumph
remove @mixes in typescript files, phetsims/scenery#1543
b4459f2
zepumph added a commit to phetsims/sun that referenced this issue Mar 9, 2023
@zepumph
remove @mixes in typescript files, phetsims/scenery#1543
3fb63c5
zepumph added a commit that referenced this issue Mar 9, 2023
@zepumph
remove @mixes in typescript files, #1543
8ddddd2
zepumph added a commit that referenced this issue Mar 9, 2023
@zepumph
PDOMInstance to use Pool, #1543
a7b02a7
@zepumph
Copy link
Member

zepumph commented Mar 9, 2023

Converted above. It was a very easy transition and all is looking good. Closing

@zepumph zepumph closed this as completed Mar 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zepumph zepumph

Labels
dev:typescript priority:3-medium
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@zepumph @marlitas