Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Voicing.voicingUtteranceQueue #1404

Closed
jessegreenberg opened this issue Apr 13, 2022 · 1 comment
Closed

Remove Voicing.voicingUtteranceQueue #1404

jessegreenberg opened this issue Apr 13, 2022 · 1 comment
Assignees
@zepumph
Labels
dev:voicing status:ready-for-review

Comments

@jessegreenberg
Copy link
Contributor

We can remove this now, there are no more usages and it doesn't seem helpful to keep. Can be removed after #1300 (comment) and phetsims/joist#800 since they are done.
@jessegreenberg jessegreenberg self-assigned this Apr 13, 2022
@jessegreenberg jessegreenberg mentioned this issue Apr 13, 2022
Closed
jessegreenberg added a commit that referenced this issue Apr 13, 2022
@jessegreenberg
Remvove voicingUtteranceQueue field of Voicing.ts, see #1404
facf80d
@jessegreenberg
Copy link
Contributor Author

It has been removed. tsc and local tests are working. @zepumph assigning to you to review if you wish, otherwise close.

@zepumph zepumph closed this as completed Jun 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zepumph zepumph

Labels
dev:voicing status:ready-for-review
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jessegreenberg @zepumph