Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Voicing.voicingFocusListener getter,setter, and mutator key #1357

Closed
zepumph opened this issue Feb 10, 2022 · 3 comments
Closed

Add Voicing.voicingFocusListener getter,setter, and mutator key #1357

zepumph opened this issue Feb 10, 2022 · 3 comments
Assignees
@zepumph
Labels
dev:voicing priority:2-high

Comments

@zepumph
Copy link
Member

zepumph commented Feb 10, 2022

From phetsims/sun#726, no reason not to complete the API in that way.
@zepumph zepumph self-assigned this Feb 10, 2022
@zepumph
Copy link
Member Author

zepumph commented Feb 10, 2022 •
edited
Loading

  • Let's also have this support null. (change usage in ComboBoxListItemNode)

@zepumph
Copy link
Member Author

zepumph commented Feb 11, 2022

I think I was just crazy 5 hours ago. This is already supported

scenery/js/accessibility/voicing/Voicing.ts

Line 52 in bd1b603

'voicingFocusListener'

I'll add support for null though.

zepumph added a commit that referenced this issue Feb 11, 2022
@zepumph
voicingFocusListener to support null, #1357
94c957d
@zepumph zepumph mentioned this issue Feb 11, 2022
Closed
@zepumph
Copy link
Member Author

zepumph commented Feb 11, 2022

This has been done. It was quite straight forward, since it was just supporting null. Closing

@zepumph zepumph closed this as completed Feb 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zepumph zepumph

Labels
dev:voicing priority:2-high
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@zepumph