Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revised AccessibleValueHandler onChange option documentation. #1239

Closed
pixelzoom opened this issue Jun 17, 2021 · 2 comments
Closed

Revised AccessibleValueHandler onChange option documentation. #1239

pixelzoom opened this issue Jun 17, 2021 · 2 comments

Comments

@pixelzoom
Copy link
Contributor

pixelzoom commented Jun 17, 2021

The documentation for AccessibleValueHandler's onChange option needs some help, see below. There are multiple typos, possibly extra or missing words. I tried to guess what it should be, but bailed. Assigned to the author.

          // Called after any change to valueProperty. Useful for "press and hold" keyboard input. However, be aware
          // that other some devices as switch will only trigger one change per input, and no concept of "press and
          // hold". This function will still be called once per input in those cases.
          onChange: _.noop,
@pixelzoom
Copy link
Contributor Author

I felt defeated, so I took another run at this. Revised doc in the above commit. @zepumph please review.

@pixelzoom pixelzoom changed the title AccessibleValueHandler onChange option documentation Revised AccessibleValueHandler onChange option documentation. Jun 17, 2021
@zepumph
Copy link
Member

zepumph commented Jun 30, 2021

Looks great to me, thanks.

@zepumph zepumph assigned pixelzoom and unassigned zepumph Jun 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants