Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iFrame maintenance release does not fix issue with various components #1215

Closed
KatieWoe opened this issue Apr 28, 2021 · 16 comments
Closed

iFrame maintenance release does not fix issue with various components #1215

KatieWoe opened this issue Apr 28, 2021 · 16 comments

Comments

@KatieWoe
Copy link

For phetsims/qa#642
In Area Model Algebra I saw this problem still present if holding down the number picker. It impacts the other Area Models and Balancing Chemical Equations. It depends on platform, happening on Chrome but not Firefox for instance, but it seems to happen with all pickers. I will add comments with any other components I see this in.
dragoutpicker

@KatieWoe
Copy link
Author

KatieWoe commented Apr 28, 2021

This also happens to a minor extent with sliders. The slider is no longer moved when released, but it stays highlighted as if it is being grabbed.
coloredslider

But this behavior doesn't happen with the bicyclist slider in EFAC Systems screen. The slider unhighlights upon re-entering the iFrame.
https://phet-dev.colorado.edu/html/energy-forms-and-changes/1.4.1-rc.1/phet/energy-forms-and-changes_en_iframe_phet.html

@phet-steele
Copy link
Contributor

phet-steele commented May 3, 2021

The following sim(s) do not seem to have this issue with pickers:

@phet-steele
Copy link
Contributor

I do see a new component that still has issues in Chrome. The tweakers in https://phet-dev.colorado.edu/html/pendulum-lab/1.0.16-rc.1/pendulum-lab_en-iframe.html do not get interrupted when releasing your mouse outside of the iframe, then dragging your mouse back in.

PL01

@phet-steele phet-steele changed the title iFrame maintenance release does not fix issue with pickers iFrame maintenance release does not fix issue with various components May 3, 2021
@KatieWoe
Copy link
Author

KatieWoe commented May 4, 2021

Some instance may be harder to find. For instance, Build an Atom has this in some game levels.

@KatieWoe
Copy link
Author

KatieWoe commented May 4, 2021

The slider issue also happens in Capacitor Lab Basics with the slider on the battery.

@KatieWoe
Copy link
Author

KatieWoe commented May 5, 2021

Another instance of the tweakers showing the issue in Forces and Motion
buttonsdontstop

@KatieWoe
Copy link
Author

KatieWoe commented May 5, 2021

Molarity has the slider issue as well

@KatieWoe
Copy link
Author

KatieWoe commented May 6, 2021

These issues happen with the pickers, sliders, and moveable points in https://phet-dev.colorado.edu/html/graphing-quadratics/1.1.6-rc.1/phet-io/graphing-quadratics_all_phet-io.html?phetioStandalone, but it does not seem to harm the mirror wrapper (things match in both sims)

@KatieWoe
Copy link
Author

KatieWoe commented May 6, 2021

Slider issue in GFL. Does not impact mirror wrapper
Molarity also has slider issue.

@KatieWoe
Copy link
Author

KatieWoe commented May 7, 2021

Examples of issues described above:
Picker is not dropped: Area Model Algebra
Slider is dropped but still highlighted: Molarity
Moveable point dropped but still highlighted: Graphing Quadratics
Tweakers not dropped: Forces and Motion Basics or Pendulum Lab

Looking for example in spinners now. Will update if I find one
Update: I saw an example in Build an Atom, but most seemed ok I think.
dothesecountbuildanatom

@jonathanolson
Copy link
Contributor

I believe these are patched in the branches, will wait to RCs.

@phet-steele
Copy link
Contributor

For phetsims/qa/issues/649 and on Win 10 Chrome, these sliders in wave-interference don't stop updating when a pointer is released outside of an iframe like shown in #1215 (comment).

image

@KatieWoe
Copy link
Author

@phet-steele do they drop when the mouse comes back in? They seem to for me.

@phet-steele
Copy link
Contributor

@phet-steele do they drop when the mouse comes back in? They seem to for me.

Oh right yup sorry, so many different behaviours I lose track of what is okay and what is not!

@KatieWoe
Copy link
Author

No problem

@jonathanolson
Copy link
Contributor

Closing, handled in maintenance release deployment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants