-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
iFrame maintenance release does not fix issue with various components #1215
Comments
This also happens to a minor extent with sliders. The slider is no longer moved when released, but it stays highlighted as if it is being grabbed. But this behavior doesn't happen with the bicyclist slider in EFAC Systems screen. The slider unhighlights upon re-entering the iFrame. |
The following sim(s) do not seem to have this issue with pickers:
|
I do see a new component that still has issues in Chrome. The tweakers in https://phet-dev.colorado.edu/html/pendulum-lab/1.0.16-rc.1/pendulum-lab_en-iframe.html do not get interrupted when releasing your mouse outside of the iframe, then dragging your mouse back in. |
Some instance may be harder to find. For instance, Build an Atom has this in some game levels. |
The slider issue also happens in Capacitor Lab Basics with the slider on the battery. |
Molarity has the slider issue as well |
These issues happen with the pickers, sliders, and moveable points in https://phet-dev.colorado.edu/html/graphing-quadratics/1.1.6-rc.1/phet-io/graphing-quadratics_all_phet-io.html?phetioStandalone, but it does not seem to harm the mirror wrapper (things match in both sims) |
Slider issue in GFL. Does not impact mirror wrapper |
I believe these are patched in the branches, will wait to RCs. |
For phetsims/qa/issues/649 and on Win 10 Chrome, these sliders in wave-interference don't stop updating when a pointer is released outside of an iframe like shown in #1215 (comment). |
@phet-steele do they drop when the mouse comes back in? They seem to for me. |
Oh right yup sorry, so many different behaviours I lose track of what is okay and what is not! |
No problem |
Closing, handled in maintenance release deployment. |
For phetsims/qa#642
In Area Model Algebra I saw this problem still present if holding down the number picker. It impacts the other Area Models and Balancing Chemical Equations. It depends on platform, happening on Chrome but not Firefox for instance, but it seems to happen with all pickers. I will add comments with any other components I see this in.
The text was updated successfully, but these errors were encountered: