Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add collectResponses.contextIncludesObjectResponse() #1214

Closed
zepumph opened this issue Apr 28, 2021 · 1 comment
Closed

Add collectResponses.contextIncludesObjectResponse() #1214

zepumph opened this issue Apr 28, 2021 · 1 comment
Assignees
@jessegreenberg
Labels
status:ready-for-review

Comments

@zepumph
Copy link
Member

zepumph commented Apr 28, 2021

This option would state that anytime a context response is provided, it is a superset of the object response and therefore omits it as redundant.

It helped greatly in a case in phetsims/ratio-and-proportion#381, and can be seen in the RaP preferences branch.
zepumph added a commit that referenced this issue Apr 28, 2021
@zepumph
add contextIncludesObjectResponse, #1214
79ff85d
jessegreenberg added a commit that referenced this issue May 18, 2021
@jessegreenberg
remove contextIncludesObjectResponse, see #1214
3e2bbd4
@jessegreenberg
Copy link
Contributor

I removed this for now, we are going with a different way of handling this in #1217 and #1207, and the usage of this option has been replaced. Closing.

jessegreenberg added a commit to phetsims/utterance-queue that referenced this issue Feb 7, 2022
@jessegreenberg
remove contextIncludesObjectResponse, see phetsims/scenery#1214
26a784a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jessegreenberg jessegreenberg

Labels
status:ready-for-review
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jessegreenberg @zepumph