You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Here is what the TinyProperty callsite currently looks like:
// @public {Property.<Dimension2>} The (integral, > 0) dimensions of the Display's DOM element (only updates the DOM// element on updateDisplay())this.sizeProperty=newTinyProperty(newDimension2(options.width,options.height),{useDeepEquality: true});
But TinyProperty doesn't take options, looking at the doc, I think this is what would actually be desired:
// @public {Property.<Dimension2>} The (integral, > 0) dimensions of the Display's DOM element (only updates the DOM// element on updateDisplay())this.sizeProperty=newTinyProperty(newDimension2(options.width,options.height));this.sizeProperty.useDeepEquality=true;
@jonathanolson does this sound right to you? How bad is this bug? Do we still need useDeepEquality, as it hasn't been implemented here since the scenery conversion from Events.
The text was updated successfully, but these errors were encountered:
It doesn't seem critical, however presumably we'd want useDeepEquality, so that we don't fire off all the changes when the size hasn't actually changed.
It looks like we're not calling it every frame, so we wouldn't see much of a penalty in sims right now.
Here is what the TinyProperty callsite currently looks like:
But TinyProperty doesn't take options, looking at the doc, I think this is what would actually be desired:
@jonathanolson does this sound right to you? How bad is this bug? Do we still need useDeepEquality, as it hasn't been implemented here since the scenery conversion from Events.
The text was updated successfully, but these errors were encountered: