Many sims are using Node.visibleProperty option wrong

[zepumph]

There are a lot of atypical usages of visibleProperty of Nodes on the project, no doubt because we have only allowed passing in a Property for 6 months, and it was a quiet release of the feature at that.

I will go around and clean up some usages. This work is from #1046

[zepumph]

I feel like "wrong" is the wrong word here. In most cases it is just not idiomatic to our normal options pattern, mostly because subtypes have been traditionally handling this logic.

[zepumph]

• I see 20 usages of visibleProperty.linkAttribute( this, in the project. Likely all of these can be refactored to use Node.visibleProperty now.

[zepumph]

Tagging #1047 as partially the base work here.

[zepumph]

I see 20 usages of visibleProperty.linkAttribute( this, in the project. Likely all of these can be refactored to use Node.visibleProperty now.

I starting going through these, and immediately felt like this was a waste of time. It was so hard to know how to test each occurrence, and the benefits seem negligible. I'm going to close this issue.

[zepumph]

I'll add that I also looked at usages of visibleProperty = in the project matching words and case, and didn't see anything else that was suspect. Most were in the model, or in the view but either a DerivedProperty or a non-standard usage.