You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
While working on #1047 and #490, @zepumph and I discussed this TODO in Node.js that says:
// TODO: Should this be set to null in the constructor, https://github.com/phetsims/scenery/issues/490constphetioVisibleProperty=newBooleanProperty(this.visible,merge({
This is later set on the Node for disposal purposes:
// When created in this manner, the phetioVisibleProperty is "owned" by this Node and we are responsible// for its disposal. Assign after calling this.visibleProperty = ... since it disposes this.phetioVisibleProperty// if it existsthis.phetioVisibleProperty=phetioVisibleProperty;
Should we set this.phetioVisibileProperty=null in the constructor? Should we add a Node.disposeEmitter that we append items to?
The text was updated successfully, but these errors were encountered:
While working on #1047 and #490, @zepumph and I discussed this TODO in Node.js that says:
This is later set on the Node for disposal purposes:
Should we set
this.phetioVisibileProperty=null
in the constructor? Should we add aNode.disposeEmitter
that we append items to?The text was updated successfully, but these errors were encountered: