Skip to content

Commit

Permalink
Additional ordering docs for phetsims/joist#725
Browse files Browse the repository at this point in the history
  • Loading branch information
jonathanolson authored and pixelzoom committed Jul 13, 2021
1 parent 971b1f5 commit e657c7e
Showing 1 changed file with 3 additions and 0 deletions.
3 changes: 3 additions & 0 deletions js/nodes/Node.js
Original file line number Diff line number Diff line change
Expand Up @@ -1278,6 +1278,9 @@ class Node extends PhetioObject {

// adjust our transform to match maximum bounds if necessary on a local bounds change
if ( this._maxWidth !== null || this._maxHeight !== null ) {
// needs to run before notifications below, otherwise reentrancy that hits this codepath will have its
// updateMaxDimension overridden by the eventual original function call, with the now-incorrect local bounds.
// See https://github.com/phetsims/joist/issues/725
this.updateMaxDimension( ourLocalBounds );
}

Expand Down

0 comments on commit e657c7e

Please sign in to comment.