Pooling improvements for phetsims/phet-core#103

js/display/SVGLinearGradient.ts

@@ -12,7 +12,12 @@ import Pool, { TPoolable } from '../../../phet-core/js/Pool.js';
 import { LinearGradient, scenery, SVGBlock, SVGGradient, svgns } from '../imports.js';
 
 export default class SVGLinearGradient extends SVGGradient implements TPoolable {
-  public override initialize( svgBlock: SVGBlock, gradient: LinearGradient ): void {
+
+  public constructor( svgBlock: SVGBlock, gradient: LinearGradient ) {
+    super( svgBlock, gradient );
+  }
+
+  public override initialize( svgBlock: SVGBlock, gradient: LinearGradient ): this {
     sceneryLog && sceneryLog.Paints && sceneryLog.Paints( `[SVGLinearGradient] initialize ${gradient.id}` );
     sceneryLog && sceneryLog.Paints && sceneryLog.push();
 
@@ -37,6 +42,8 @@ export default class SVGLinearGradient extends SVGGradient implements TPoolable
     this.definition.setAttribute( 'y2', '' + linearGradient.end.y );
 
     sceneryLog && sceneryLog.Paints && sceneryLog.pop();
+
+    return this;
   }
 
   /**

js/display/SVGRadialGradient.ts

@@ -12,6 +12,11 @@ import Pool, { TPoolable } from '../../../phet-core/js/Pool.js';
 import { RadialGradient, scenery, SVGBlock, SVGGradient, svgns } from '../imports.js';
 
 export default class SVGRadialGradient extends SVGGradient implements TPoolable {
+
+  public constructor( svgBlock: SVGBlock, gradient: RadialGradient ) {
+    super( svgBlock, gradient );
+  }
+
   public override initialize( svgBlock: SVGBlock, radialGradient: RadialGradient ): this {
     sceneryLog && sceneryLog.Paints && sceneryLog.Paints( `[SVGRadialGradient] initialize ${radialGradient.id}` );
     sceneryLog && sceneryLog.Paints && sceneryLog.push();

js/input/BatchedDOMEvent.ts

@@ -38,13 +38,15 @@ export default class BatchedDOMEvent implements TPoolable {
     this.initialize( domEvent, type, callback );
   }
 
-  public initialize( domEvent: Event, type: BatchedDOMEventType, callback: BatchedDOMEventCallback ): void {
+  public initialize( domEvent: Event, type: BatchedDOMEventType, callback: BatchedDOMEventCallback ): this {
     // called multiple times due to pooling, this should be re-entrant
     assert && assert( domEvent, 'for some reason, there is no DOM event?' );
 
     this.domEvent = domEvent;
     this.type = type;
     this.callback = callback;
+
+    return this;
   }
 
   public run( input: Input ): void {

js/layout/LayoutProxy.ts

@@ -45,8 +45,10 @@ export default class LayoutProxy {
    *
    * DO not call it twice without in-between disposals (follow the above pattern).
    */
-  public initialize( trail: Trail ): void {
+  public initialize( trail: Trail ): this {
     this.trail = trail;
+
+    return this;
   }
 
   private checkPreconditions(): void {

js/layout/constraints/FlowLine.ts

@@ -28,12 +28,14 @@ export default class FlowLine extends LayoutLine {
   /**
    * (scenery-internal)
    */
-  public initialize( orientation: Orientation, cells: FlowCell[] ): void {
+  public initialize( orientation: Orientation, cells: FlowCell[] ): this {
 
     this.orientation = orientation;
     this.cells = cells;
 
     this.initializeLayoutLine();
+
+    return this;
   }
 
   /**
@@ -53,7 +55,7 @@ export default class FlowLine extends LayoutLine {
   /**
    * (scenery-internal)
    */
-  public static readonly pool = new Pool<typeof FlowLine, [Orientation, FlowCell[]]>( FlowLine, {
+  public static readonly pool = new Pool( FlowLine, {
     defaultArguments: [ Orientation.HORIZONTAL, [] ]
   } );
 }

js/layout/constraints/GridLine.ts

@@ -28,14 +28,16 @@ export default class GridLine extends LayoutLine {
   /**
    * (scenery-internal)
    */
-  public initialize( index: number, cells: GridCell[], grow: number ): void {
+  public initialize( index: number, cells: GridCell[], grow: number ): this {
     this.index = index;
 
     this.cells = cells;
 
     this.grow = grow;
 
     this.initializeLayoutLine();
+
+    return this;
   }
 
   /**
@@ -48,7 +50,7 @@ export default class GridLine extends LayoutLine {
   /**
    * (scenery-internal)
    */
-  public static readonly pool = new Pool<typeof GridLine, [number, GridCell[], number]>( GridLine, {
+  public static readonly pool = new Pool( GridLine, {
     defaultArguments: [ 0, [], 0 ]
   } );
 }

js/util/SpriteInstance.ts

@@ -59,9 +59,11 @@ export default class SpriteInstance {
   /**
    * For pooling. Please use SpriteInstance.dirtyFromPool() to grab a copy
    */
-  private initialize(): void {
+  public initialize(): this {
     // We need an empty initialization method here, so that we can grab dirty versions and use them for higher
     // performance.
+
+    return this;
   }
 
   /**