Only set PhetioObject fields for instrumented PhetioObjects in PhET-i…

…O brand, phetsims/tandem#224
phetsims · Nov 11, 2020 · 4879f62 · 4879f62
1 parent f259087
commit 4879f62
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 3 deletions.
diff --git a/js/nodes/Node.js b/js/nodes/Node.js
@@ -170,6 +170,7 @@ import inherit from '../../../phet-core/js/inherit.js';
 import merge from '../../../phet-core/js/merge.js';
 import platform from '../../../phet-core/js/platform.js';
 import PhetioObject from '../../../tandem/js/PhetioObject.js';
+import Tandem from '../../../tandem/js/Tandem.js';
 import BooleanIO from '../../../tandem/js/types/BooleanIO.js';
 import IOType from '../../../tandem/js/types/IOType.js';
 import NullableIO from '../../../tandem/js/types/NullableIO.js';
@@ -5503,7 +5504,7 @@ inherit( PhetioObject, Node, {
 
     PhetioObject.prototype.initializePhetioObject.call( this, baseOptions, config );
 
-    if ( !wasInstrumented && this.isPhetioInstrumented() ) {
+    if ( Tandem.PHET_IO_ENABLED &&  !wasInstrumented && this.isPhetioInstrumented() ) {
 
       // For each supported TinyForwardingProperty, if a Property was already specified in the options (in the
       // constructor or mutate), then it will be set as this.targetProperty there. Here we only create the default

diff --git a/js/nodes/RichText.js b/js/nodes/RichText.js
@@ -294,7 +294,7 @@ class RichText extends Node {
 
     super.initializePhetioObject( baseOptions, config );
 
-    if ( !wasInstrumented && this.isPhetioInstrumented() ) {
+    if ( Tandem.PHET_IO_ENABLED && !wasInstrumented && this.isPhetioInstrumented() ) {
 
       this._textProperty.initializePhetio( this, TEXT_PROPERTY_TANDEM_NAME, () => new StringProperty( this.text, merge( {
 

diff --git a/js/nodes/Text.js b/js/nodes/Text.js
@@ -234,7 +234,7 @@ inherit( Node, Text, {
 
     Node.prototype.initializePhetioObject.call( this, baseOptions, config );
 
-    if ( !wasInstrumented && this.isPhetioInstrumented() ) {
+    if ( Tandem.PHET_IO_ENABLED && !wasInstrumented && this.isPhetioInstrumented() ) {
       this._textProperty.initializePhetio( this, TEXT_PROPERTY_TANDEM_NAME, () => new StringProperty( this.text, merge( {
 
           // by default, use the value from the Node