Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GrabDragInteraction should factor out model for reuse #867

Closed
zepumph opened this issue Aug 27, 2024 · 3 comments
Closed

GrabDragInteraction should factor out model for reuse #867

zepumph opened this issue Aug 27, 2024 · 3 comments

Comments

@zepumph
Copy link
Member

zepumph commented Aug 27, 2024

From phetsims/density-buoyancy-common#368, we keep a Mass model instance around for multiple copies of the MassView (which creates the GrabDragInteraction). So let's make a grabDragInteractionModel that can be persistent through different grabDragInteraction instances. And perhaps such that multiple views can update the same model (for cue logic). We will see!

@zepumph
Copy link
Member Author

zepumph commented Aug 27, 2024

I got to a commit point:

zepumph added a commit that referenced this issue Aug 27, 2024
zepumph added a commit to phetsims/density-buoyancy-common that referenced this issue Aug 27, 2024
zepumph added a commit to phetsims/density-buoyancy-common that referenced this issue Aug 28, 2024
zepumph added a commit that referenced this issue Aug 28, 2024
@zepumph
Copy link
Member Author

zepumph commented Aug 28, 2024

Noting that some of the above may overlap with #869. Note that issue too.

@zepumph
Copy link
Member Author

zepumph commented Sep 3, 2024

All items have been checked above. Not all because they are done; many will be handled over in #869. Closing

@zepumph zepumph closed this as completed Sep 3, 2024
zepumph added a commit that referenced this issue Sep 3, 2024
Signed-off-by: Michael Kauzmann <[email protected]>
zepumph added a commit to phetsims/density-buoyancy-common that referenced this issue Sep 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant