-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
In the StopwatchNode, allow adding additional buttons and/or removing the play/pause/rewind buttons #843
Comments
…tion to omit the play/pause and reset buttons, see #843
@matthew-blackman and I implemented it above and will request review as part of phetsims/projectile-data-lab#32 |
In code review phetsims/projectile-data-lab#32 ...
My first thought was that I would not use StopwatchNode here, since it's significantly different from the standard StopwatchNode. But @samreid and @matthew-blackman explained that they wanted to leverage everything else that comes with StopwatchNode. That said, I hate to see more features added to StopwatchNode, but I don't see anything wrong with b491faf. I did add links to this issue in 12c83d2. |
Thanks, let's close this issue. We have more stopwatch work to do in phetsims/projectile-data-lab#180 and will continue there. |
As part of the design for phetsims/projectile-data-lab#94 (comment), we agreed we wanted to customize the StopwatchNode by adding a sim-specific button and removing the rewind/play/pause buttons. I described this would complicate the API and implementation of StopwatchNode, but we agreed this was important and worth the effort.
The text was updated successfully, but these errors were encountered: