Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove dispose code in Keyboard Help Content #810

Closed
zepumph opened this issue Jun 1, 2023 · 2 comments
Closed

Remove dispose code in Keyboard Help Content #810

zepumph opened this issue Jun 1, 2023 · 2 comments
Assignees
@jessegreenberg
Labels
status:ready-for-review

Comments

@zepumph
Copy link
Member

zepumph commented Jun 1, 2023

https://github.com/phetsims/phet-io/issues/1810 we removed the need to dispose in Keyboard help content.
zepumph added a commit that referenced this issue Jun 8, 2023
@zepumph
remove dispose code in keyboard help, #810
5c8e9e3 
Signed-off-by: Michael Kauzmann <[email protected]>
zepumph added a commit to phetsims/geometric-optics that referenced this issue Jun 8, 2023
@zepumph
remove dispose code in keyboard help, phetsims/scenery-phet#810
ca25c99 
Signed-off-by: Michael Kauzmann <[email protected]>
zepumph added a commit to phetsims/my-solar-system that referenced this issue Jun 8, 2023
@zepumph
remove dispose code in keyboard help, phetsims/scenery-phet#810
4c6e8d5 
Signed-off-by: Michael Kauzmann <[email protected]>
zepumph added a commit to phetsims/gravity-force-lab that referenced this issue Jun 8, 2023
@zepumph
remove dispose code in keyboard help, phetsims/scenery-phet#810
7d7cd23 
Signed-off-by: Michael Kauzmann <[email protected]>
zepumph added a commit to phetsims/ph-scale that referenced this issue Jun 8, 2023
@zepumph
remove dispose code in keyboard help, phetsims/scenery-phet#810
1e218bb 
Signed-off-by: Michael Kauzmann <[email protected]>
zepumph added a commit to phetsims/coulombs-law that referenced this issue Jun 8, 2023
@zepumph
remove dispose code in keyboard help, phetsims/scenery-phet#810
596af40 
Signed-off-by: Michael Kauzmann <[email protected]>
zepumph added a commit to phetsims/faradays-law that referenced this issue Jun 8, 2023
@zepumph
remove dispose code in keyboard help, phetsims/scenery-phet#810
764d71c 
Signed-off-by: Michael Kauzmann <[email protected]>
zepumph added a commit to phetsims/joist that referenced this issue Jun 8, 2023
@zepumph
remove dispose code in keyboard help, phetsims/scenery-phet#810
2094f15 
Signed-off-by: Michael Kauzmann <[email protected]>
zepumph added a commit to phetsims/fourier-making-waves that referenced this issue Jun 8, 2023
@zepumph
remove dispose code in keyboard help, phetsims/scenery-phet#810
86d4c5a 
Signed-off-by: Michael Kauzmann <[email protected]>
@zepumph
Copy link
Member Author

zepumph commented Jun 8, 2023

@jessegreenberg can you find anything else that I missed here? I looked for dispose in scenery-phet/keyboard/helpand inKeyboardHelp` (file mask).

@zepumph zepumph removed their assignment Jun 8, 2023
@jessegreenberg
Copy link
Contributor

Looks good, I did a skim through a few of the above commits and also checked for dispose in scenery-phet/js/keyboard/help. Thanks for doing this. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jessegreenberg jessegreenberg

Labels
status:ready-for-review
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jessegreenberg @zepumph