Rename SimColorProfile.js files to SimColors.js

[samreid]

From #515, we would like to rename sim color files to be SimColors.js instead of SimColorProfile.js. #515 is getting a bit long, so I moved this to a side issue.

[samreid]

In the above commit, the docs are pointing to the old style ColorProfile.js names, I decided to make it consistent until we can address all occurrences.

[samreid]

@pixelzoom said in #515 (comment)

I'd like to shed the "ColorProfile" baggage, and call this file MyRepoColors.js. And I intend to put both ColorDef and ProfileColorProperty instances in this file.

[samreid]

call this file MyRepoColors.js

Before I work on converting these files, can we decide on the casing? Should it be myRepoColors.js or MyRepoColors.js?

[pixelzoom]

Here's what I (mostly) see being done across the PhET code base. We've never formalized this, but I think it makes sense.

• If the file exports an instance of a class (has a constructor), then it's a singleton, and use lowercase. Like soundManager.js.

• If the file exports an object literal that's a collection of constants, use uppercase, e.g. MyRepoConstants.js.

What we're doing here for colors feels like the latter, so MyRepoColors.js.

[samreid]

OK I renamed files to SimColors.js. @pixelzoom would you like to spot check?

[pixelzoom]

👍🏻 closing.