-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
default options need adjusting in ZoomButtonGroup hierarchy #653
Comments
Ditto for cornerRadius. |
Ditto for |
Ditto for |
In the above commits, I've adjusted the default options so that:
@samreid please review. |
I reviewed the commits and tested the default components in the scenery-phet harness, and tested the buttons in CCK-AC. Everything looks good to me, thanks! Closing. |
Related to #652. Something I noticed as I'm converting ph-scale to MagnifyingGlassZoomButtonGroup in phetsims/ph-scale#206...
ZoomButton uses
buttonAppearanceStrategy: RectangularButton.ThreeDAppearanceStrategy
(the default), while ZoomButtonGroup usesbuttonAppearanceStrategy: RectangularButton.FlatAppearanceStrategy
.If we want to convert sims from ZoomButton to MagnifyingGlassZoomButtonGroup, and have them look the same as they do now, that means that every sim is going to have to set
buttonAppearanceStrategy: RectangularButton.ThreeDAppearanceStrategy
for MagnifyingGlassZoomButtonGroup. And we don't want to do that.So I think the buttonAppearanceStrategy
override should be moved from ZoomButtonGroup to PlusMinusZoomButtonGroup, so that MagnifyingGlassZoomButtonGroup uses 3D buttons. And if @samreid needs them to be flat in CCK:AC, then override
buttonAppearanceStrategy` there.The text was updated successfully, but these errors were encountered: