-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ZoomButtonGroup pointer areas should support an arbitrary spacing #650
Comments
I'll take care of this one. Should be quick. |
Implemented in the above commits, with a demo in scenery-phet Components screen for PlusMinusZoomButtonGroup. Run with
@samreid want to take a look? |
Here are the pointer areas without the shift: Here are the pointer areas with the shift: It seems like the intention is to keep the same shape and just move them, but in some cases it may be desirable to truncate the overlap instead of shifting the entire areas. I'm not recommending a change for this, just wanted to bring it up for the record. It seems reasonable to shift the entire areas so they have the same "footprint". And the effect I described could be achieved by changing the dilations. I also considered factoring out a function that computes the touch area at once instead of mutating it, but the given implementation seems clearer. In short, nice work! Closing. |
From a discussion in phetsims/circuit-construction-kit-common#620, @pixelzoom and I discussed that ZoomButtonGroup pointer areas should support an arbitrary spacing. At the moment, it looks like it assumes the spacing is 0.
@ariel-phet can you please recommend a priority and developer?
The text was updated successfully, but these errors were encountered: