-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Keypad should use nested options for its NumberAccumulator #541
Comments
Right now [in Keypad.js] I have to omit the parent tandem before passing in the child one: // @private {function}
this.keyAccumulator = options.accumulator ? options.accumulator : new NumberAccumulator( merge( {
tandem: options.tandem.createTandem( 'numberAccumulator' )
}, _.omit( options, 'tandem' ) ) ); |
I don't see any opportunities for using nested options in NumberAccumulator. @zepumph Do you mean that KeyPad should use nested options for its NumberAccumulator subcomponent? EDIT: I'm going with "yes". |
I'm going to work on this issue, self assigning. |
There are 5 occurrences of
The complete set of NumberAccumulator options (including AbstractKeyAccumulator superclass) is:
|
Options In additon to testing all sims that use Keypad, I inspected the Studio tree in projectile-motion (screenshot below) and it looks correct. @zepumph would you mind doing a quick review, since you created this issue? |
Looks really nice. Thanks |
Discovered while working on #540. Tagging @Denz1994 to see what he thinks.
The text was updated successfully, but these errors were encountered: