-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create new Utterance for "activation" alerts #492
Comments
Created and used in ResetAllButton in the above commit. |
Also used in NavigationBarSoundToggleButton. I inspected instances of @zepumph could you please review? Mostly, are you OK with the name ActivationUtterance? |
Following a similar pattern, we are going to create a special type of Utterance that will assist with alerts that happen after a value changes called ValueChangeUtterance. |
Done, and ready for review again. |
@jessegreenberg, above I updated ISLC suite sims to use @terracoda could you please review the timing of alerts in GFLB. They just changed from the above commits, and I think your thoughts on them could inform the final outcome of this issue. Basically checkbox alerts will be a bit longer (~half a second as an "Activation Utterance"), and position/mass changes will be a fair bit longer (~one second as a "Value Change Utterance"). Does this work for GFLB? Do you think that these would work in general for most sims? |
I agree, it is a bit longer than ideal. We landed on 1000 ms in phetsims/john-travoltage#315 because we discovered that JAWS has a hard time reading alerts if they happen too quickly after reading aria-valuetext. I added a missing reference link in the doc. If we want to reduce the time, we will want to test changes against JAWS and VO. |
@jessegreenberg when I worked with sim on Friday, and the alerts seemed slow. I will review again, and post here on Monday. |
@jessegreenberg, the alerts feel like they appear in the orange box a little slowly when using the A11y View, but I think they sound fine when I use the sim with VoiceOver. |
@jessegreenberg, I'm going to close this issue. Pleas ere-open if I closed prematurely. |
The changes in #491 are generally good for most utterances, but there are a category of Utterances that will need a longer
alertStableDelay
so that alerts generally don't get repeated when you press and hold down buttons. We are seeing now that if you press and hold the ResetAllButton, you will get two "reset" alerts because thealertStableDelay
is longer than the default press and hold delay for activation with the "enter" key.Potential names:
I like ActivationUtterance the best because it aligns with the W3C term for pressing things. I also like ButtonUtterance and ClickUtterance. But maybe we will want this for more than buttons and clicks.
The text was updated successfully, but these errors were encountered: