Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NumberControl title font regression #347

Closed
jonathanolson opened this issue Jan 24, 2018 · 2 comments
Closed

NumberControl title font regression #347

jonathanolson opened this issue Jan 24, 2018 · 2 comments
Assignees
@zepumph
Labels
type:bug

Comments

@jonathanolson
Copy link
Contributor

It looks like 43003c9#diff-22cf8008e26ed989c8977040d76d6913 added titleFontWeight (with a default of 'normal') to NumberControl.

The font weight is generally included in the Font object (which titleFont should be), so I don't see why it should be separate. This change also made the pendulum lab titles non-bold (when they specify a bold font).

@zepumph, as it looks like this was added as part of phetsims/rutherford-scattering#128, do you mind if I remove all usages of titleFontWeight, and convert any usages into using the correct weight in the font?
jonathanolson added a commit to phetsims/rutherford-scattering that referenced this issue Jan 24, 2018
@jonathanolson
Including boldness in titleFont, see phetsims/scenery-phet#347
830e51c
jonathanolson added a commit that referenced this issue Jan 24, 2018
@jonathanolson
Removing titleFontWeight and its override, see #347
42b94b4
@jonathanolson
Copy link
Contributor Author

Decided I could move forward and implement the changes. Closing.

@zepumph
Copy link
Member

zepumph commented Feb 19, 2018 •
edited
Loading

Thanks for fixing this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zepumph zepumph

Labels
type:bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jonathanolson @zepumph