Keypad: decimal point is not localized

[pixelzoom]

Identical problem that was present in the old keypad, #279.

The decimal point is not localized, it's hardcoded (and duplicated) in multiple places in Keypad. E.g.:

245 [ new Key( '.', KeyID.DECIMAL ), new Key( '0', KeyID.ZERO ), new Key( ( new BackspaceIcon( { scale: 1.5 } ) ), KeyID.BACKSPACE ) ]

[jbphet]

Ah yes, that did indeed get missed in the implementation of the new keypad. The GitHub issue that @pixelzoom links above - #279 - has a lot of information that will be germane to the implementation of this feature and should be used as a reference. I'll close that issue, and note that it is superseded by this one.

At one point in the discussion in #279 @ariel-phet says,

@jbphet I think we can automatically decide. it seems this convention is well established in various locales, and something we do not need to rely upon to be done by our translators.

I'm taking this to mean that in order to address this problem, code will be added to the keypad that will automatically decide based upon the locale whether to use a comma or a period as the decimal separator, and the decimal separator will not be settable via the translation utility.

Assigning to @ariel-phet to assign and prioritize, and to @pixelzoom to confirm that the proposed solution sounds workable. If we need to reconsider this decision and revisit the idea of making the decimal separate explicitly translatable, let's mark it for dev meeting and see if we can come to a final decision there.

[pixelzoom]

I'm not sure what the best solution is to this problem. But decisions made in https://github.com/phetsims/dot/issues/68 (i18n: decimal comma separator) should be applied here.

[ariel-phet]

@jbphet keypad is getting lots of use. I think it would be good for you to tackle this issue once Gene Expression is in the testing cycle.

Agreed with the proposed solution that keypad will automatically decided based on locale

[jbphet]

Assigning to @Denz1994 for followup once #283 has been addressed.

[jbphet]

A user recently logged an issue related to this, see https://github.com/phetsims/dot/issues/68. There is also one in the rosetta repo, see phetsims/rosetta#252. When (and if) I or someone else starts working on localization of the decimal separator, the first step should be to organize and consolidate the related issues.

[jbphet]

The issue of decimal point localization was discussed during the 4/8/2021 Q2 planning meeting, see notes in phetsims/rosetta#263 (comment). Based on this, I'm marking this issue as deferred for now and will un-defer once we can get to work on it.