Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WavelengthSlider: use pixels instead of percentages for thumb touchArea defaults #266

Closed
pixelzoom opened this issue Aug 29, 2016 · 1 comment
Closed

WavelengthSlider: use pixels instead of percentages for thumb touchArea defaults #266

pixelzoom opened this issue Aug 29, 2016 · 1 comment
Assignees
@pixelzoom

Comments

@pixelzoom
Copy link
Contributor

In light of phetsims/sun#251 (comment), options for pointer areas should be changed to pixels instead of percentages. Review clients to see if this adversely affects them.
@pixelzoom pixelzoom self-assigned this Aug 29, 2016
@pixelzoom pixelzoom mentioned this issue Aug 29, 2016
Closed
pixelzoom added a commit to phetsims/models-of-the-hydrogen-atom that referenced this issue Aug 29, 2016
@pixelzoom
change touchArea defaults to pixels, adjust clients, phetsims/scenery…
61cf9e7 
…-phet#266
pixelzoom added a commit that referenced this issue Aug 29, 2016
@pixelzoom
change touchArea defaults to pixels, adjust clients, #266
668576c
@pixelzoom
Copy link
Contributor Author

Work completed. I inspected all clients (BLL, bending-light, color-vision, MOTHA). The only client that required adjustment was MOTHA, which is an unpublished sim for which I'm responsible. So I'm going to go ahead and close this issue. But if any other developer wants to review, please do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pixelzoom pixelzoom

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@pixelzoom