Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WavelengthSlider needs additional options #260

Closed
pixelzoom opened this issue Aug 22, 2016 · 4 comments
Closed

WavelengthSlider needs additional options #260

pixelzoom opened this issue Aug 22, 2016 · 4 comments
Assignees

Comments

@pixelzoom
Copy link
Contributor

Noted while working on models-of-the-hydrogen-atom.

If you decrease options.trackHeight, then the value may collide with the buttons, e.g.:

screenshot_79

So it would be nice to be able to control the size of the tweaker buttons, and the vertical spacing between the bottom of the value and the top of the track.

@pixelzoom pixelzoom self-assigned this Aug 22, 2016
@pixelzoom pixelzoom changed the title WavelengthSlider need additional options WavelengthSlider needs additional options Aug 22, 2016
pixelzoom added a commit that referenced this issue Aug 22, 2016
pixelzoom added a commit that referenced this issue Aug 22, 2016
@pixelzoom
Copy link
Contributor Author

Added options.ySpacing and options.maxTweakersHeight, working nicely in MOTHA:

screenshot_80

@samreid Would you mind taking a peek?

@samreid
Copy link
Member

samreid commented Aug 23, 2016

All 3 commits look good, my only question is whether we would like a more specific term in place of ySpacing, perhaps something like verticalValueDisplayMargin? It seems like ySpacing runs the risk of colliding with some future term.

@samreid samreid assigned pixelzoom and unassigned samreid Aug 23, 2016
pixelzoom added a commit that referenced this issue Aug 23, 2016
pixelzoom added a commit to phetsims/models-of-the-hydrogen-atom that referenced this issue Aug 23, 2016
@pixelzoom
Copy link
Contributor Author

Changed ySpacing to valueYSpacing.

@pixelzoom pixelzoom assigned samreid and unassigned pixelzoom Aug 23, 2016
@samreid
Copy link
Member

samreid commented Aug 23, 2016

Sounds good, closing.

@samreid samreid closed this as completed Aug 23, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants