Skip to content

Commit

Permalink
don't add focus highlight as a child in NumberControl, #341
Browse files Browse the repository at this point in the history
  • Loading branch information
zepumph committed Oct 25, 2017
1 parent 43003c9 commit d394b9d
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion js/NumberControl.js
Original file line number Diff line number Diff line change
Expand Up @@ -209,7 +209,7 @@ define( function( require ) {
innerStroke: FocusHighlightPath.FOCUS_COLOR, // make both the inner and outer focus color be the same
visible: false
}, true );
this.addChild( numberControlFocusHighlightBorder );
// this.addChild( numberControlFocusHighlightBorder ); // TODO: don't change the bounds of NumberControl by adding this, see https://github.com/phetsims/scenery-phet/issues/341
slider.focusChangedEmitter.addListener( function( isFocused ) {
numberControlFocusHighlightBorder.visible = isFocused;
} );
Expand Down

1 comment on commit d394b9d

@pixelzoom
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reverted because this broke phetsims/hookes-law#47

Please sign in to comment.