Skip to content

Commit

Permalink
TODO ANSWER: yes, they should be optional, phetsims/chipper#1360
Browse files Browse the repository at this point in the history
  • Loading branch information
pixelzoom committed Jan 30, 2023
1 parent b9a0611 commit c7b070a
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 2 deletions.
1 change: 0 additions & 1 deletion js/GroundNode.ts
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,6 @@ import { Color, TColor } from '../../scenery/js/imports.js';
import GradientBackgroundNode from './GradientBackgroundNode.js';
import sceneryPhet from './sceneryPhet.js';

// TODO CM: should these be optional, or should we remove the defaults? https://github.com/phetsims/chipper/issues/1360
type SelfOptions = {
topColor?: TColor;
bottomColor?: TColor;
Expand Down
1 change: 0 additions & 1 deletion js/SkyNode.ts
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,6 @@ import { Color, TColor } from '../../scenery/js/imports.js';
import GradientBackgroundNode from './GradientBackgroundNode.js';
import sceneryPhet from './sceneryPhet.js';

// TODO CM: should these be optional, or should we remove the defaults? https://github.com/phetsims/chipper/issues/1360
type SelfOptions = {
topColor?: TColor;
bottomColor?: TColor;
Expand Down

0 comments on commit c7b070a

Please sign in to comment.