dispose of ArrowButton instances, #259

phetsims · Aug 23, 2016 · a1361fa · a1361fa
1 parent 1650643
commit a1361fa
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 2 deletions.
diff --git a/js/NumberControl.js b/js/NumberControl.js
@@ -186,10 +186,15 @@ define( function( require ) {
 
     // @private
     this.disposeNumberControl = function() {
+
       numberDisplay.dispose();
+      leftArrowButton.dispose();
+      rightArrowButton.dispose();
+      slider.dispose();
+
       numberProperty.unlink( arrowEnabledListener );
       thisNode.enabledProperty.unlink( enabledObserver );
-      slider.dispose();
+
       options.tandem && options.tandem.removeInstance( thisNode );
     };
 

diff --git a/js/WavelengthSlider.js b/js/WavelengthSlider.js
@@ -222,8 +222,10 @@ define( function( require ) {
     options.tandem && options.tandem.addInstance( this, TNode );
 
     this.disposeWavelengthSlider = function() {
-      options.tandem && options.tandem.removeInstance( this );
+      plusButton && plusButton.dispose();
+      minusButton && minusButton.dispose();
       wavelength.unlink( wavelengthListener );
+      options.tandem && options.tandem.removeInstance( this );
     };
   }