move roundToStepSize to options, see phetsims/coulombs-law#72

phetsims · Oct 23, 2018 · 6ab271b · 6ab271b
1 parent acfb7a5
commit 6ab271b
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 6 deletions.
diff --git a/js/FaucetNode.js b/js/FaucetNode.js
@@ -88,7 +88,10 @@ define( function( require ) {
 
       tandem: Tandem.required,
       phetioType: FaucetNodeIO,
-      phetioEventType: 'user'
+      phetioEventType: 'user',
+
+      // a11y - when using keyboard, flowRateProperty will round to nearest keyboardStep of AccessibleSlider
+      roundToStepSize: true
     }, options );
 
     assert && assert( ( 1000 * options.tapToDispenseAmount / options.tapToDispenseInterval ) <= maxFlowRate );
@@ -279,7 +282,6 @@ define( function( require ) {
     self.mutate( options );
 
     // mix accessible slider functionality into this node
-    options.roundToStepSize = true;
     this.initializeAccessibleSlider(
       flowRateProperty,
       new Property( new Range( 0, maxFlowRate ) ),

diff --git a/js/NumberControl.js b/js/NumberControl.js
@@ -117,7 +117,8 @@ define( function( require ) {
       phetioType: NumberControlIO,
 
       // a11y
-      groupFocusHighlight: true
+      groupFocusHighlight: true,
+      roundToStepSize: true
     }, options );
 
 
@@ -215,7 +216,6 @@ define( function( require ) {
       // where it makes no sense to call them startDrag and endDrag.
       startDrag: options.sliderStartCallback || options.startCallback,
       endDrag: options.sliderEndCallback || options.endCallback,
-      roundToStepSize: true,
       tandem: options.tandem.createTandem( 'slider' )
     } );
 

diff --git a/js/SpectrumSlider.js b/js/SpectrumSlider.js
@@ -91,7 +91,10 @@ define( function( require ) {
       cursorStroke: 'black',
 
       // phet-io
-      tandem: Tandem.required
+      tandem: Tandem.required,
+
+      // a11y - should valueProperty round to the nearest interval of AccessibleSlider stepSize when using keyboard?
+      roundToStepSize: true
 
     }, options );
 
@@ -312,7 +315,6 @@ define( function( require ) {
     };
 
     // mix accessible slider functionality into HSlider
-    options.roundToStepSize = true;
     var rangeProperty = new Property( new Range( options.minValue, options.maxValue ) );
     this.initializeAccessibleSlider( valueProperty, rangeProperty, new BooleanProperty( true ), options );
   }