Skip to content

Commit

Permalink
Fix adjacent overload signatures, see: phetsims/chipper#1250
Browse files Browse the repository at this point in the history
  • Loading branch information
marlitas committed May 26, 2022
1 parent b4fc53a commit 59e2111
Show file tree
Hide file tree
Showing 4 changed files with 12 additions and 9 deletions.
3 changes: 2 additions & 1 deletion js/Drawer.ts
Original file line number Diff line number Diff line change
Expand Up @@ -285,14 +285,15 @@ export default class Drawer extends Node {

set animationEnabled( value ) { this.setAnimationEnabled( value ); }

get animationEnabled() { return this.getAnimationEnabled(); }

/**
* Is animation enabled for opening/closing drawer?
*/
public getAnimationEnabled(): boolean {
return this._animationEnabled;
}

get animationEnabled() { return this.getAnimationEnabled(); }
}

sceneryPhet.register( 'Drawer', Drawer );
7 changes: 4 additions & 3 deletions js/EyeDropperNode.ts
Original file line number Diff line number Diff line change
Expand Up @@ -167,16 +167,17 @@ export default class EyeDropperNode extends Node {
this.setFluidColor( value );
}

get fluidColor() {
return this.getFluidColor();
}

/**
* Gets the color of the fluid in the dropper.
*/
public getFluidColor(): IPaint {
return this.fluidNode.fill;
}

get fluidColor() {
return this.getFluidColor();
}
}

sceneryPhet.register( 'EyeDropperNode', EyeDropperNode );
8 changes: 4 additions & 4 deletions js/NumberDisplay.ts
Original file line number Diff line number Diff line change
Expand Up @@ -287,17 +287,17 @@ export default class NumberDisplay extends Node {

set backgroundFill( value: IPaint ) { this.setBackgroundFill( value ); }

get backgroundFill(): IPaint {
return this.getBackgroundFill();
}

/**
* Gets the background fill.
*/
getBackgroundFill(): IPaint {
return this.backgroundNode.fill;
}

get backgroundFill(): IPaint {
return this.getBackgroundFill();
}

/**
* Sets the background stroke.
*/
Expand Down
3 changes: 2 additions & 1 deletion js/ValueGaugeNode.ts
Original file line number Diff line number Diff line change
Expand Up @@ -78,14 +78,15 @@ export default class ValueGaugeNode extends GaugeNode {

set numberDisplayVisible( visible ) { this.setNumberDisplayVisible( visible ); }

get numberDisplayVisible() { return this.getNumberDisplayVisible(); }

/**
* Gets the visibility of the gauge's NumberDisplay.
*/
public getNumberDisplayVisible(): boolean {
return this._numberDisplayVisible;
}

get numberDisplayVisible() { return this.getNumberDisplayVisible(); }

public override dispose(): void {
this.numberDisplay.dispose();
Expand Down

0 comments on commit 59e2111

Please sign in to comment.