Skip to content

Commit

Permalink
forbid _.extend to define options or config (prefer merge), phetsims/…
Browse files Browse the repository at this point in the history
  • Loading branch information
zepumph committed Nov 7, 2019
1 parent 8ddfd3c commit 50fa4bb
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion js/capacitor/CapacitorNode.js
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ define( require => {
const Bounds2 = require( 'DOT/Bounds2' );
const CapacitorConstants = require( 'SCENERY_PHET/capacitor/CapacitorConstants' );
const EFieldNode = require( 'SCENERY_PHET/capacitor/EFieldNode' );
const merge = require( 'PHET_CORE/merge' );
const Node = require( 'SCENERY/nodes/Node' );
const Orientation = require( 'PHET_CORE/Orientation' );
const PlateNode = require( 'SCENERY_PHET/capacitor/PlateNode' );
Expand All @@ -39,7 +40,7 @@ define( require => {
*/
constructor( circuit, modelViewTransform, plateChargeVisibleProperty, electricFieldVisibleProperty, options ) {

options = _.extend( {
options = merge( {
orientation: Orientation.VERTICAL
}, options );
super();
Expand Down

0 comments on commit 50fa4bb

Please sign in to comment.