Simplified _.extend call and clarified assert messages, see #243

phetsims · Jul 6, 2016 · 0d6b589 · 0d6b589
1 parent 7c1cb4a
commit 0d6b589
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/js/buttons/StepBackwardButton.js b/js/buttons/StepBackwardButton.js
@@ -18,8 +18,8 @@ define( function( require ) {
    * @constructor
    */
   function StepBackwardButton( options ) {
-    assert && assert( !options.direction, 'options.direction must not be specified for StepBackwardButton' );
-    StepButton.call( this, _.extend( {}, options, { direction: 'backward' } ) );
+    assert && assert( !options.direction, 'options.direction must be omitted for StepBackwardButton' );
+    StepButton.call( this, _.extend( { direction: 'backward' }, options ) );
   }
 
   sceneryPhet.register( 'StepBackwardButton', StepBackwardButton );

diff --git a/js/buttons/StepForwardButton.js b/js/buttons/StepForwardButton.js
@@ -19,8 +19,8 @@ define( function( require ) {
    * @constructor
    */
   function StepForwardButton( options ) {
-    assert && assert( !options.direction, 'options.direction must not be specified for StepForwardButton' );
-    StepButton.call( this, _.extend( {}, options, { direction: 'forward' } ) );
+    assert && assert( !options.direction, 'options.direction must be omitted for StepForwardButton' );
+    StepButton.call( this, _.extend( { direction: 'forward' }, options ) );
   }
 
   sceneryPhet.register( 'StepForwardButton', StepForwardButton );