Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

step button is always enabled #143

Closed
jessegreenberg opened this issue Aug 24, 2018 · 3 comments
Closed

step button is always enabled #143

jessegreenberg opened this issue Aug 24, 2018 · 3 comments
Assignees
@jessegreenberg
Labels
type:bug

Comments

@jessegreenberg
Copy link
Contributor

Found with @zepumph while working on what is very likely an unrelated issue phetsims/scenery#831. The step button is always enabled, it should be disabled when playing.
@jessegreenberg jessegreenberg self-assigned this Aug 24, 2018
jessegreenberg added a commit that referenced this issue Aug 27, 2018
@jessegreenberg
playingProperty -> isPlayingProperty for stepButton, see #143
129aa0d
@jessegreenberg
Copy link
Contributor Author

It looks like there was a change to use StepButton's isPlayingProperty option, but it was using playingProperty instead. Ill check to see if this happened anywhere else.

@jessegreenberg
Copy link
Contributor Author

jessegreenberg commented Aug 27, 2018 •
edited
Loading

The option was renamed in phetsims/scenery-phet#388.

@jessegreenberg
Copy link
Contributor Author

Handled in phetsims/scenery-phet#388

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jessegreenberg jessegreenberg

Labels
type:bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jessegreenberg