Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

replace pg-query #167

Closed
jbphet opened this issue Nov 21, 2017 · 1 comment
Closed

replace pg-query #167

jbphet opened this issue Nov 21, 2017 · 1 comment
Assignees
@jbphet
Labels
priority:4-low

Comments

@jbphet
Copy link
Contributor

jbphet commented Nov 21, 2017

pg-query doesn't seem to have much support - it's at version 0.11.0 and hasn't been updated for a long time. I tried to update pg to a newer version, but it caused problems with pg-query, and I had to revert (see #166 (comment)). I think the only way that we will be able to update pg - which would be a good thing to do - is to replace pg-query with something else, possibly pg-promises.

I'll mark this as low priority for chipper:2.0, since it's not absolutely vital that it get done, but it would be good in the long run.
@jbphet jbphet self-assigned this Nov 21, 2017
@jbphet jbphet assigned zepumph and unassigned jbphet Apr 23, 2018
@mbarlow12 mbarlow12 self-assigned this Aug 30, 2018
mbarlow12 added a commit that referenced this issue Oct 3, 2018
@mbarlow12
dev environment files added to dev/, updated documentation to reflect…
69300aa 
… new Docker option, add env variables for use with 'pg' module, see #167
@zepumph zepumph removed their assignment Oct 24, 2018
@jbphet jbphet mentioned this issue May 17, 2019
Closed
jbphet added a commit that referenced this issue Jun 12, 2019
@jbphet
made startup wait for DB connect test, made DB params required, see #167
274f327
@ariel-phet ariel-phet assigned jbphet and unassigned mbarlow12 Jul 2, 2019
jbphet added a commit that referenced this issue Nov 25, 2019
@jbphet
steps towards improved DB interaction and code, see #167 and #208
c7b6667
jbphet added a commit that referenced this issue Nov 25, 2019
@jbphet
updated version of pg package, see #167 and #208
efa4784
jbphet added a commit that referenced this issue Nov 25, 2019
@jbphet
trying a different approach for DB connection, see #167 and #208
f036675
jbphet added a commit that referenced this issue Nov 25, 2019
@jbphet
lint fix, see #167 and #208
ba50b51
jbphet added a commit that referenced this issue Nov 25, 2019
@jbphet
trying out pools for DB connection, see #167 and #208
c1ff694
jbphet added a commit that referenced this issue Nov 25, 2019
@jbphet
improved pool usage, see #167 and #208
4b1dadb
jbphet added a commit that referenced this issue Nov 25, 2019
@jbphet
better output for pool query test, see #167 and #208
b3891dd
jbphet added a commit that referenced this issue Nov 25, 2019
@jbphet
trying async for pool query test, see #167 and #208
57ace39
jbphet added a commit that referenced this issue Nov 25, 2019
@jbphet
improved info message for pool test, minor cleanup, see #167 and #208
ab02ac2
jbphet added a commit that referenced this issue Nov 25, 2019
@jbphet
migrated DB interactions from pg-query to pg, see #167 and #208
bc50080
@jbphet
Copy link
Contributor Author

jbphet commented Dec 5, 2019

This is done and has been deployed on phet-server. Related work was done in #208. Closing.

@jbphet jbphet closed this as completed Dec 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jbphet jbphet

Labels
priority:4-low
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jbphet @mbarlow12 @zepumph