-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Is the read out for minimum length supposed to be 0.00...01? #177
Comments
That sounds incorrect, its reading the value of the "Length" slider, and it sounds like the formatting isn't right. |
Oh, for some reason it is reading the "min" and "max" values for the slider? I have never heard that before. he min value in the PDOM is |
Hearing the recording again, it is saying "min 0.100...001", so it is a precision issue maybe. |
Likely a problem with AccessibleSlider so assigning to myself. |
I don't see anywhere where the "min" attribute could pick up extra decimals in I am not hearing this in JAWS with FF 62, but JAWS isn't reading min and max values for the slider when it receives focus. Ill see if I can figure out how to turn that on in user settings or something. |
OK, I hear it now, only happens when reading through with the virtual cursor (not on focus). Here is the HTML for the slider: <label tabindex="-1" id="label-247-310-321-388-387-386-346-349" for="247-310-321-388-387-386-346-349">L, Length</label>
<input style="width: 1px; height: 1px;" id="247-310-321-388-387-386-346-349" tabindex="0" role="slider" aria-orientation="vertical" step="0.1" min="0.1" max="20" aria-valuetext="10.00 centimeters" type="range"> Ill try to reproduce in a JSFiddle. |
I was able to reproduce in this JSFiddle: https://jsfiddle.net/au7rhbg8/ Ill start removing attributes until the problem goes away. (if it goes away) |
Seems to just happen for some "min" values for sliders. For example, this slider with min=0.3 reads the min value (only when using the virtual cursor) as "0.299999....". I think that we should submit a bug report to VFO, add to the list of AT quirks, and close this issue. @terracoda @zepumph what do you think? |
Here is a very basic slider where the bug is coming up, Ill probably use this one in the bug report. |
I went ahead and reported FreedomScientific/standards-support#112. I documented in our internal tracking https://docs.google.com/document/d/1518zv6F0odExFsodShZxwTmWNQk3civuNwtQUR-rEBs/edit. OK to close this issue? |
If you think we’re done, then it’s OK to close from QA’s standpoint. But perhaps @terracoda and @zepumph will have something to say, so I’ll leave it open for now. |
Sounds good to close. @jessegreenberg isn't there a place to document this sort of weirdness so qa has a list of know bugs to check before submitting issues to developers? I would recommend adding this there. |
There is, sorry I mentioned in an edit to #177 (comment) that I added a note there. |
Alright we have 👍 s from everyone so I think we can close! |
Does happen in phetsims/qa#476, but not always consistently. |
https://drive.google.com/file/d/1hexjqYRExi6u7Doq8CGbOSHKlDqNFM3y/view?usp=sharing |
Sounds right, I don't see any progress on the Freedom Scientific issue. |
Here's what JAWS sounds like when it reads the "Slider Controls" h3:
https://drive.google.com/open?id=1-IBXvhnGrQo0n4jlHKwDEd5MomSDyFMl
For
phetsims/qa#179phetsims/qa#183.The text was updated successfully, but these errors were encountered: