Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Safari camera settings not working correctly with rc.2 #543

Closed
Tracked by #874
Nancy-Salpepi opened this issue Dec 13, 2022 · 5 comments
Closed
Tracked by #874

Safari camera settings not working correctly with rc.2 #543

Nancy-Salpepi opened this issue Dec 13, 2022 · 5 comments
Labels

Comments

@Nancy-Salpepi
Copy link

Test device
MacBook Air (m1 chip)

Operating System
macOS 13.0.1

Browser
safari 16.1

Problem description
For phetsims/qa#863, I have my safari camera setting set to "ask," but when I add ?cameraInput=hands, nothing happens. I have to go into my safari settings and change to "allow" in order for the camera to turn on. I didn't have this issue with rc.1. The camera works as it should.

Visuals

cameraSettings.mp4

Screenshot 2022-12-13 at 2 44 06 PM

Troubleshooting information: !!!!! DO NOT EDIT !!!!! Name: ‪Ratio and Proportion‬ URL: https://phet-dev.colorado.edu/html/ratio-and-proportion/1.2.0-rc.2/phet/ratio-and-proportion_all_phet.html Version: 1.2.0-rc.2 2022-12-05 22:59:52 UTC Features missing: applicationcache, applicationcache, touch Flags: pixelRatioScaling User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/108.0.0.0 Safari/537.36 Language: en-US Window: 1581x816 Pixel Ratio: 1.7999999523162842/1 WebGL: WebGL 1.0 (OpenGL ES 2.0 Chromium) GLSL: WebGL GLSL ES 1.0 (OpenGL ES GLSL ES 1.0 Chromium) Vendor: WebKit (WebKit WebGL) Vertex: attribs: 16 varying: 31 uniform: 1024 Texture: size: 16384 imageUnits: 16 (vertex: 16, combined: 32) Max viewport: 16384x16384 OES_texture_float: true Dependencies JSON: {}
@Nancy-Salpepi Nancy-Salpepi added the type:bug Something isn't working label Dec 13, 2022
@Nancy-Salpepi
Copy link
Author

I am seeing the same issue with macOS 10.15.7 + safari 15.6.1. With my safari camera settings set to "ask" for the phet-dev website, I get this message with rc.1, but not rc.2:
Screenshot 2022-12-13 at 2 23 22 PM

@zepumph
Copy link
Member

zepumph commented Dec 17, 2022

I was not able to make much progress on this today, next step is to test if this works on my iPad.

zepumph added a commit to phetsims/tangible that referenced this issue Jan 3, 2023
zepumph added a commit to phetsims/tangible that referenced this issue Jan 3, 2023
@zepumph
Copy link
Member

zepumph commented Jan 3, 2023

@jessegreenberg was able to help me debug this and found that in many cases, the deviceID from the browser is '', so the default value of most device ids (which is also the empty string) often doesn't trigger it to start the stream.

@jessegreenberg and I couldn't get to the bottom of why this bug was occurring in rc.2 but not rc.1, but we have confirmed this fixed on master.

Also note that this was effecting all devices we tested, including chrome and windows. The reason it wasn't showing up often was because most of our testing links had already "allowed" camera, so it didn't automatically reproduce until resetting the camera permission. Ready for cherry pick.

@zepumph zepumph removed their assignment Jan 3, 2023
zepumph added a commit to phetsims/tangible that referenced this issue Jan 3, 2023
@zepumph
Copy link
Member

zepumph commented Jan 3, 2023

Cherry picked. QA, feel free to close if all is well.

@Nancy-Salpepi
Copy link
Author

Camera settings working correctly with rc.3. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants