Voicing compares hand location to same hand

[Nancy-Salpepi]

Test device
MacBook Air (m1 chip)

Operating System
macOS 13.0.1

Browser
safari 16.1 and chrome

Problem description
For phetsims/qa#852, when moving the left hand, voicing compares its location to 'left hand' and the same thing happens when moving the right hand.

Steps to reproduce

1. Turn on Voicing and check Sim Voicing Options checkboxes
2. On either screen, move left hand --new position compared to left hand
3. Move right hand--new position compared to right hand

Visuals

wronghandcomparison.mov

Troubleshooting information: !!!!! DO NOT EDIT !!!!! Name: ‪Ratio and Proportion‬ URL: https://phet-dev.colorado.edu/html/ratio-and-proportion/1.2.0-rc.1/phet/ratio-and-proportion_all_phet.html Version: 1.2.0-rc.1 2022-11-11 22:40:36 UTC Features missing: applicationcache, applicationcache, touch Flags: pixelRatioScaling User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/107.0.0.0 Safari/537.36 Language: en-US Window: 1544x712 Pixel Ratio: 1.7999999523162842/1 WebGL: WebGL 1.0 (OpenGL ES 2.0 Chromium) GLSL: WebGL GLSL ES 1.0 (OpenGL ES GLSL ES 1.0 Chromium) Vendor: WebKit (WebKit WebGL) Vertex: attribs: 16 varying: 31 uniform: 1024 Texture: size: 16384 imageUnits: 16 (vertex: 16, combined: 32) Max viewport: 16384x16384 OES_texture_float: true Dependencies JSON: {}

[Nancy-Salpepi]

I also see this issue with VoiceOver and in a11y view

[zepumph]

Well that is less than ideal!!

Looks like the bug is not in https://phet-dev.colorado.edu/html/ratio-and-proportion/1.2.0-dev.31/phet/ratio-and-proportion_all_phet.html?printVoicingResponses&voicingInitiallyEnabled&preferencesStorage, and is in https://phet-dev.colorado.edu/html/ratio-and-proportion/1.2.0-dev.32/phet/ratio-and-proportion_all_phet.html?printVoicingResponses&voicingInitiallyEnabled&preferencesStorage. I'll take a look.

[zepumph]

94f074f has the bug, 5ee9dc4 does not.

[zepumph]

Classic, looks like the bug was introduced by a simple mistake in d4f186a#diff-b1e62322eee34f09e99fbdae2de1b90ed22ebae29b875e92c7bf5567705483a2L284.

[zepumph]

Fixed by 91fa9af, to cherry pick that.

[zepumph]

Done and ready for confirmation in next version.

[Nancy-Salpepi]

This looks good in 1.2.0-rc.2 with Voicing, VoiceOver and a11y view on mac + safari. Will reopen if anything comes up.