Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Artwork needed for Camera Input: Hands #493

Closed
Tracked by #539 ...
terracoda opened this issue Aug 12, 2022 · 59 comments
Closed
Tracked by #539 ...

Artwork needed for Camera Input: Hands #493

terracoda opened this issue Aug 12, 2022 · 59 comments
Assignees
Labels
type:bug Something isn't working

Comments

@terracoda
Copy link
Contributor

terracoda commented Aug 12, 2022

Over in #491, we are working out the words to describe how customize the hand movement.

Here's how I currently have it described

Customize hand movement.
[ ] Flip camera view of hands between frontal and horizontal views
[ ] Flip hand operation between mirrored hand control and opposite hand control

Here are some sample hand drawings
image
Sample hands from https://all-free-download.com/free-vector/download/free-vector-hands-human-hands_38058.html

Then connect a natural looking hand with the sim's hands... (working on an example)

@terracoda
Copy link
Contributor Author

terracoda commented Aug 12, 2022

These are not very good. Just tryin to get an idea across for frontal camera view with the hands
Directly mirrored, or
hand-mirrored

Opposite hand control
hands-opposite

@terracoda
Copy link
Contributor Author

@emily-phet, could you elaborate on what you have in mind for a graphic?

@terracoda
Copy link
Contributor Author

Maybe we need a sim screen in front of the human hands?

@zepumph
Copy link
Member

zepumph commented Aug 19, 2022

This is blocking publication of the sim. What are the goals here?

@terracoda
Copy link
Contributor Author

Personally, I don't think this should block publication as long as the text is understandable.

@terracoda
Copy link
Contributor Author

terracoda commented Aug 22, 2022

Here's a rough idea with a screen in front of the hands.
image

image

image

@zepumph
Copy link
Member

zepumph commented Aug 22, 2022

It isn't clear to me what artwork you are interested it. What size generally do you want this? Is it an icon? Something for the options dialog as well as the website if we were going to filter on it/put it next to sims that supported it? Perhaps the "screen" portion of it should be general and not sim-specific. Like two hands and a blurry screen background or something. If you were trying to have an image showing how RAP works in the options Dialog, then my ideas are not the direction to go.

@terracoda
Copy link
Contributor Author

terracoda commented Aug 23, 2022

I hadn't considered a blurry screen. That's an interesting idea.

And actually, it needs to be very simple - iconic in nature and ideally black and white. I was just using the image from the home screen button because I can't seem to draw.

Ideally, a screen on an angle with hands in front would be good.

@terracoda
Copy link
Contributor Author

Is this better @zepumph

Camera Input: Hands
With "cameraInput=hands" use your hands to move the sim's Left and Right Hands.

Customize hand movement
[ ] Flip camera view of hands between frontal and horizontal views
image

[ ] Flip hand operation between mirrored hand control and opposite hand control
image

@terracoda
Copy link
Contributor Author

I think we may need better images of the hands, but I think we are getting closer to simple and iconic.

@terracoda
Copy link
Contributor Author

Another options for

[ ] Flip camera view of hands between frontal and horizontal views
image

@terracoda
Copy link
Contributor Author

@emily-phet and @zepumph, assigning to you both for comment.

@terracoda
Copy link
Contributor Author

terracoda commented Aug 23, 2022

I like the original order now, too. Mirrored ot not mirrored - frontal vertical view or over-the-top horizontal view.

Camera Input: Hands
With "cameraInput=hands" use your hands to move the sim's Left and Right Hands.

Customize hand movement
[ ] Flip hand operation between mirrored hand control and opposite hand control
image

[ ] Flip camera view of hands between frontal and horizontal views
image

@emily-phet
Copy link

@terracoda Did you reach out to @Ashton-Morris about this? If not, I can ask him if he could put something together quickly for this when I have some afternoon meetings with him. JB is out so we'll have time for that.

@Ashton-Morris Ashton-Morris self-assigned this Aug 23, 2022
@Ashton-Morris
Copy link

I am going to brainstorm and try to come up with some ideas.

@terracoda
Copy link
Contributor Author

Thanks @Ashton-Morris, I forgot to reach out to you.

@Ashton-Morris
Copy link

Screen Shot 2022-09-28 at 1 25 50 PM
I have tried with some various perspectives. What do you all think?

@terracoda
Copy link
Contributor Author

terracoda commented Sep 28, 2022

These look way more interesting than the ones I hacked together.

I personally like the straight-on perspective as I can see the letters there the best.
image

@emily-phet
Copy link

I like the straight on perspective, or the upper left one in your comment above.
Let's have the sim hands look like the hands in the sim RAP, and distinguish them from the representation of the real human hands.
Also - if the dimensions of the screen could be narrower, that would be great. Right now it looks more like a TV than a computer screen to me.

@terracoda
Copy link
Contributor Author

The one in the upper left was my second favourite

@Ashton-Morris
Copy link

Update: I have made it more like a monitor a bit. Also added the Sim hands.

Should the sim hands be intentionally red still or do you all think black and white only would be best?
Screen Shot 2022-10-04 at 12 02 17 PM

@zepumph
Copy link
Member

zepumph commented Oct 6, 2022

Since we have such good progress here, I'm going to mark this as blocking to keep the conversation going.

In terms of adding this to the controls themselves:

  • We could make this a radio button group where the icons are the UI.
  • We could add like a "double arrow" swap to the icon and keep the flipping checkbox
  • We could highlight the "selected" icon when checked, and grey out the other.

@terracoda what are you thinking about the above icons?

@terracoda what are you thinking about the final form of the preference.

@zepumph
Copy link
Member

zepumph commented Oct 6, 2022

Next steps here from a conversation with @emily-phet:

  1. We like a "toggle" style icon UI, something like Color Vision or Balancing Act:

image
image

  1. Create heading for the UI. Something like "Flip hands up/down" and "Flip hands left/right"
  2. Do we need additional onscreen text in addition? @emily-phet and I aren't quite sure. This is a question for @terracoda, if so, then we need to figure out how to attach that to the heading/icon combo.
  3. Solidify the images. I think that we should work with @Ashton-Morris to solidify the design and then we can give the idea to @mariahmaephet.

zepumph added a commit to phetsims/tangible that referenced this issue Nov 24, 2022
zepumph added a commit to phetsims/quadrilateral that referenced this issue Nov 24, 2022
@zepumph
Copy link
Member

zepumph commented Nov 24, 2022

Alrighty!

How's this?

image

I have a preference to keep things sim-independent. But I'm happy to keep this of you'd prefer. These options live best in common code, and not in RAP (other sims will likely want to implement features to flix these dimensions).

Let me know what you'd like to do.

@emily-phet
Copy link

emily-phet commented Nov 24, 2022

Looks great!

I agree - it would be ideal if this info was general, but we struggled with that. So let's go with this.

@emily-phet emily-phet assigned zepumph and unassigned emily-phet Nov 24, 2022
@zepumph
Copy link
Member

zepumph commented Nov 25, 2022

Alrighty. To cherrypick: The three commits above that aren't in Quad.

@terracoda
Copy link
Contributor Author

Yep, looks great!

@zepumph
Copy link
Member

zepumph commented Dec 5, 2022

Cherry picked and ready for confirmation in the new version.

zepumph added a commit to phetsims/tangible that referenced this issue Dec 5, 2022
zepumph added a commit to phetsims/tangible that referenced this issue Dec 5, 2022
zepumph added a commit that referenced this issue Dec 5, 2022
@KatieWoe
Copy link
Contributor

KatieWoe commented Dec 7, 2022

The control checkboxes are reversed in RC.2. The Y axis box switches direction and the x axis box switches hands. This is the opposite of what is described.

@KatieWoe KatieWoe added the type:bug Something isn't working label Dec 7, 2022
@zepumph
Copy link
Member

zepumph commented Dec 8, 2022

Yes thanks. Let's pick this up and cherry pick it in #538. Everything here is done as far as I know. Thanks all!

@zepumph zepumph closed this as completed Dec 8, 2022
@zepumph zepumph mentioned this issue Dec 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:bug Something isn't working
Projects
None yet
Development

No branches or pull requests

6 participants