ComboBox voicing response on selection broken

[zepumph]

I can reproduce this in the voice combobox in the voicing preferences, and also in the my challenge combo box. I'll take a look. I believe this is a regression, though it could have been part of the design. I thought it should say the selection when you press it. This is broken for mouse and keyboard.

[zepumph]

Discovered while poking around phetsims/joist#813

[zepumph]

Ahhh, @jessegreenberg, we have broken voicing responses on combobox selection because of voicingVisible. The listbox get's hidden, so we don't hear it even though the combobox code hasn't changed.

https://github.com/phetsims/sun/blob/811a46cb8e395efbbe0e59dd603af474c5d5d045/js/ComboBoxListBox.ts#L311-L326

I'll investigate a way to voice through a visible part of the combobox.

[zepumph]

@terracoda please note here, feel free to test if you'd like and let me know if you run into trouble.

@jessegreenberg, will you give me a spot check here?

[terracoda]

The Voice combobox sounds good on open and upon selection of new voice.
Oh, this is assigned to @jessegreenberg to verify.

[zepumph]

Looks like I missed the contextResponse as part of this issue. Fixed in phetsims/sun@ec1d8fd.

[jessegreenberg]

Great, this is working well thank you for fixing this.

I thought briefly about moving this into ComboBoxButton somehow so that we didn't have to add to the ComboBoxListBox constructor args. But I think this needs to happen in the ComboBoxListBox FireListener.