Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Both hands context response is capitalized in voicing response #461

Closed
zepumph opened this issue Apr 14, 2022 · 3 comments
Closed

Both hands context response is capitalized in voicing response #461

zepumph opened this issue Apr 14, 2022 · 3 comments

Comments

@zepumph
Copy link
Member

zepumph commented Apr 14, 2022

This makes good sense for description, but not in voicing, I think it would be straight forward to fix. Here is what things look like right now:

hands, far from challenge ratio, Hands extremely close to each other, left almost on tick mark 4.5, right on tick mark 5.5.
hands, at challenge ratio, Hands very close to each other, left in lower region, right in upper-middle region.
@zepumph zepumph self-assigned this Apr 14, 2022
@terracoda
Copy link
Contributor

Are you proposing to have no capitals on the phrases? This does make sense since all periods have been removed, and we just have concatenated phrases & sentence fragments.

@terracoda
Copy link
Contributor

I am inclined to not address this issue right now.
The broader question is what do we want to do with sentence capitalization of Context responses, in general?

@samreid
Copy link
Member

samreid commented Oct 4, 2022

Discovered in phetsims/chipper#946, there are TODOs remaining in the code. Reopening.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants