-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert to typescript #404
Comments
Big work that I'm putting off right now:
|
I started with about 1350 compiler errors when converting all resources to |
After the above commits, I am down to 500 compile errors. |
So far, I have found ~3 actual bugs (boolean passed in for number, or null for number, etc), and about 5-10 cleanup pieces, like extra parameters passed in that were ignored. |
…her common code are broken), phetsims/ratio-and-proportion#404
Branch merged, lint and ts compile errors have been either fixed or worked around. |
There are still a fair number of usage of merge that I kept around because the supertype isn't in typescript yet. I thought that was easiest. I also got rid of a bunch of ts-ignore usages. All that are left are from old-style mixins. |
010ffb4 was a documentation and general Typescript review. I haven't updated options, |
Ok, I have done all the optionize that I can do at this time. I'll wait for more common code to be converted. Other TODOs will be discussed during this week's dev meeting. |
Ok! I got rid of many TODOs here, still some remain as common code is not yet in typescript yet (SoundClip, SoundGenerator, ScreenIcon, KeyboardHelpSection).
|
A couple more TODOs taken care of here since SoundClip and SoundGenerator are now typescript. |
The only thing left for this issue is to convert KeyboardHelpSection code to typescript once those common code types are complete. |
New convention to adopt: initialize in the declaration site when possible. |
I went through all files. Closing! |
…eAccordionBox.ts (requiring many updates to phet-types.d.ts), phetsims/ratio-and-proportion#404
Discussed during quarterly planning last week, every developer is to take on converting a sim to typescript to take the new language for a test drive. Since this sim is my next sim I'm going to be working on (for voicing), I will start here, and with https://github.com/phetsims/chipper/blob/master/doc/typescript-quick-start.md. My expectation is that it will take one day (8 hours).
Note phetsims/tasks#1096
The text was updated successfully, but these errors were encountered: